Update Headers on Reconnect

[smitt04]

I am connecting to aws IoT using a custom authorizer. To do this i am using the SetHTTPHeaders to add additional headers during connection. It would be nice if we could also do this on reconnect. There is a way to provide credentials on reconnect but that doesn't work for me, need to add additional headers.

[smitt04]

any interest in this?

[MattBrittan]

Sorry for not replying earlier (somehow missed this one; there have been significant changes since it was raised!). c.options.OnConnectAttempt was added very recently in #497; as there will only be one or two people using this I think that adding the ability to set headers in this call would be OK if you want to submit a PR?

[smitt04]

I was just looking through my code and realized I had a comment about this issue, so I decided to look into it again. Didn't realize that 1.3+ has been released. I was looking at the changes and noticed this PR which is basically what I am looking for I think? I would have to test it. Do you think that would work? or should we update the c.options.OnConnectAttempt function to also call the same?

For my use case I get my auth first then create the connection by setting headers. I was never able to use auto reconnect because It would try to reconnect with a bad auth token. With the OnReconnecting callback i should be able to update the token before continuing

[MattBrittan]

I think c.options.OnConnectAttempt will need to be changed because the client maintains a private copy of the options (c.options) so you will not be able to edit c.options.HTTPHeaders that from within the current call. I wonder if it would make more sense to just pass c.options to c.options.OnConnectAttempt (and perhaps accept the options back and take a copy of them - modifying these while the library is running could cause all kinds of issues). However this may be a little confusing as attemptConnection() takes a copy of c.options.Servers so it would not be possible to change the servers.

[MattBrittan]

Sorry - just noticed that you were talking about OnReconnecting not OnConnectAttempt. That should do the trick (so I think the change you requested is already in place).

[smitt04]

Yes, i forgot to post the link to #283

[smitt04]

#283 fixes the issues of reconnection headers by adding the headers on reconnection attempt. Will re-open if it does not work for my use case. Thanks.