Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"publish was broken by timeout" when WriteTimeout=0 #334

Closed
MattBrittan opened this issue Jul 11, 2019 · 0 comments
Closed

"publish was broken by timeout" when WriteTimeout=0 #334

MattBrittan opened this issue Jul 11, 2019 · 0 comments

Comments

@MattBrittan
Copy link
Contributor

I am getting "publish was broken by timeout" on approximately 10% of publish calls with the latest master.

It appears that this is due to PR #326 which calls time.After(c.options.WriteTimeout) (client.go:604). If WriteTimeout is 0 (the default) then its possible that both options in the select statement will be ready so one will be chosen at random. Unfortunately when this happens the publish message is lost (I do not have code to deal with that because it should not be necessary with the filestore enabled).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant