Add Proxy to WebsocketOptions #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fulder
force-pushed
the
master
branch
2 times, most recently
from
3730ecf
to
23b35d7
Compare
Signed-off-by: Michal Sadowski <misad90@gmail.com>
Signed-off-by: Michal Sadowski <misad90@gmail.com>
fulder
force-pushed
the
master
branch
3 times, most recently
from
8ea88ba
to
39c2d72
Compare
Signed-off-by: Michal Sadowski <misad90@gmail.com>
|
No activity in nine months. This PR would be helpful when proxy isn't set with HTTP_PROXY environment variables. How ca we bring this PR forward? |
|
Apologies - this came through before I became a committer and I did not notice it when reviewing outstanding commits. Looks good to me. |
|
@MattBrittan no worries, thank you for the review and merge 👍 |
|
Great! Thanks for the quick response @MattBrittan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for custom proxy function for websocket Dialer instead of hardcoding it to
http.ProxyFromEnvironment. This hardcode can cause unexpected behavior during use cases where the proxy is changed during runtime ashttp.ProxyFromEnvironmentwill only look it up once during the first call.Also added a warning log if websocket handshake fails due to e.g. invalid status code (other than 101). This response slurped and returned by the
Dialfunction was just ignored and made debugging harder.