New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HTTP Connect proxy support #496
Comments
Please feel free to submit a PR, however it will not be possible to accept it until you have signed the ECA (it's a fairly simple process and is important in order to ensure the code is appropriately licensed). |
@MattBrittan: I've created an account and signed an ECA against the same github account as I'm pushing from.
|
@amir-khassaia you will not be able to push a branch to this repo; the standard process is to create a fork and generate the pull request from that |
PR done but ECA doesn't appear to be recognized - I've signed and resigned the ECA and double checked the emails match. Will revisit again later. |
I can see that you have signed the ECA - there have been some changes made to the ECA verification recently (sign-off within comment no longer needed) so it's possible that this is broken (I cannot see anything obviously wrong). Given that I have no issues with the ECA but have made a few comments (am concerned about adding more complexity into this package, especially when there are side effects like in |
Agree, I've left comments along the similar thinking in the PR too: #497 (comment)
|
Reworked the PR to adhere to the above discussion |
Resolved in #497, closing. |
Raising this as a request to support connections via HTTP forwarding/tunneling proxies in addition to SOCKS proxies that are already natively supported. It seems that other paho flavours already have support for this too.
It's possible to work with proxies better by supporting connection tunneling offered by HTTP/CONNECT for compatible proxies as defined in https://tools.ietf.org/html/rfc7231#section-4.3.6.
This works by having the compliant proxy transparently relaying the data and the client issues the connect just writes the data to the proxy without needing to know much more.
Can submit a PR, I've not yet signed an ECA as a contributor though.
Related to #394
The text was updated successfully, but these errors were encountered: