Does Xtend work with java records? #2823

tripleo1 · 2023-10-18T16:41:24Z

I am testing Xtend with a Java 17 project and it complains about record classes:

Starting a Gradle Daemon (subsequent builds will be faster)

> Task :project:generateXtext FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':project:generateXtext'.
> Cannot handle type public @SuppressWarnings("unused") record GRecord(Parm1 parm1, Parm2 parm2, Supplier<Dep2> arg3) {

plugins { id "org.xtext.xtend" version "4.0.0" }

java {
    sourceCompatibility = JavaVersion.VERSION_17
    targetCompatibility = JavaVersion.VERSION_17
}

The text was updated successfully, but these errors were encountered:

cdietrich · 2023-10-18T16:45:08Z

hi, can you please provide more information what you are actually doing?

tripleo1 · 2023-10-18T16:51:49Z

hi, can you please provide more information what you are actually doing?

I just dropped the gradle plugin into an existing java project, and am trying to get a clean build.

On a side note, I don't really like records: Should I just convert the records to Xtend?

cdietrich · 2023-10-18T17:01:15Z

there is no record in xtend. there is also no in java source lang.
so the gradle plugin would be able to parse the java files i guess
which xtext version do you use?

cdietrich · 2023-10-18T17:04:53Z

Caused by: java.lang.IllegalArgumentException: Cannot handle type public record MyRecord(String a, int b) {
/* Implicit */  private final String a;
/* Implicit */  private final int b;
  public MyRecord(String a, int b) {
    .a = a;
    .b = b;
  }
}
        at org.eclipse.xtext.java.resource.JavaDerivedStateComputer.createType(JavaDerivedStateComputer.java:130)
        at org.eclipse.xtext.java.resource.JavaDerivedStateComputer.installStubs(JavaDerivedStateComputer.java:107)
        at org.eclipse.xtext.java.resource.JavaResource.lambda$0(JavaResource.java:174)
        at org.eclipse.xtext.java.resource.JavaResource.initializing(JavaResource.java:190)
        at org.eclipse.xtext.java.resource.JavaResource.installStubs(JavaResource.java:173)
        at org.eclipse.xtext.java.resource.JavaResourceDescriptionManager.getResourceDescription(JavaResourceDescriptionManager.java:48)

cdietrich · 2023-10-18T17:07:10Z

question would be if record can easily be mapped to a class
otherwise this could be a bigger thing.

tripleo1 · 2023-10-18T17:22:17Z

Caused by: java.lang.IllegalArgumentException: Cannot handle type public record MyRecord(String a, int b) {
/* Implicit */  private final String a;
/* Implicit */  private final int b;
  public MyRecord(String a, int b) {
    .a = a;
    .b = b;
  }
}
        at org.eclipse.xtext.java.resource.JavaDerivedStateComputer.createType(JavaDerivedStateComputer.java:130)
        at org.eclipse.xtext.java.resource.JavaDerivedStateComputer.installStubs(JavaDerivedStateComputer.java:107)
        at org.eclipse.xtext.java.resource.JavaResource.lambda$0(JavaResource.java:174)
        at org.eclipse.xtext.java.resource.JavaResource.initializing(JavaResource.java:190)
        at org.eclipse.xtext.java.resource.JavaResource.installStubs(JavaResource.java:173)
        at org.eclipse.xtext.java.resource.JavaResourceDescriptionManager.getResourceDescription(JavaResourceDescriptionManager.java:48)

I am assuming this is the same problem that I have...
it could be said then that Xtend does not support Java records?
What does this even mean?

there is no record in xtend.

My assumption is correct, then.
I willl learn more about the language grammar.

there is also no in java source lang.

I know it generates 8,
(5b) but I'm not sure about anything else.

which xtext version do you use?

find ~/.gradle/caches/jars-9 -name '*xtext*.jar'
/home/user/.gradle/caches/jars-9/80e6104f623c271fb1ec71b8d3a7b8b2/org.eclipse.xtext.xbase.lib-2.17.1.jar
/home/user/.gradle/caches/jars-9/1024beae751fc6fe2dd8a11a7969799c/xtext-gradle-plugin-4.0.0.jar
/home/user/.gradle/caches/jars-9/275f80d50eb809b8abebdb57ce829556/org.eclipse.xtext.xbase.lib-2.17.1.jar
/home/user/.gradle/caches/jars-9/4c9b4dd18261ca3f0bb4f1d9bdd9bde1/xtext-gradle-plugin-4.0.0.jar

Who know which one it will choose?

cdietrich · 2023-10-18T17:24:00Z

You don’t have an explicit xbase/xtend.lib dependency in your project ?

cdietrich · 2023-10-18T17:24:25Z

I wonder if you face the same problem in a maven project

tripleo1 · 2023-10-18T17:31:46Z

You don’t have an explicit xbase/xtend.lib dependency in your project ?

oh, there we go:

implementation 'org.eclipse.xtend:org.eclipse.xtend.lib:2.30.0'

I wonder if you face the same problem in a maven project

what could possibly be the difference?

cdietrich · 2023-10-18T17:56:00Z

Maven links against class files and not java files
Thus we might be better at eating records but I don’t know
(at least until you use the record)

rasifix · 2023-11-09T08:54:21Z

We are also having the same issue with records. The records are consumed by Xtext when building the index for Java classes. I see two possible solutions:

xtext ignores records and issues a warning (in many cases those records are irrelevant for Xtext code generation)
xtext learns how to deal with records

Point two should not be a big issue as records are really just syntactic sugar. i.e. they are just normal Java classes with some special properties (fields are final, accessor methods, constructor with all properties, ...). So, IMHO, this would be a straightforward and desirable fix.

LorenzoBettini · 2023-11-09T08:56:12Z

If I understand correctly, the Ecore model of Xtext Java bundle should be updated with records first, shouldn't it?

rasifix · 2023-11-09T08:57:09Z

I don't think this is really necessary. Records are just Java classes.

cdietrich · 2023-11-09T08:58:11Z

we at least need to transform them to classes.
am not sure what @szarnekow recommends

LorenzoBettini · 2023-11-09T09:00:01Z

At least, this switch, which throws the exception,

xtext/org.eclipse.xtext.java/src/org/eclipse/xtext/java/resource/JavaDerivedStateComputer.java

Line 115 in bc28645

switch (TypeDeclaration.kind(type.modifiers)) {

, should be updated somehow accordingly.

cdietrich · 2023-11-09T09:01:20Z

yes but this also affect the code that runs in eclipse
JdtTypeProvider or something the like

rasifix · 2023-11-09T09:20:27Z

At least, this switch, which throws the exception,

xtext/org.eclipse.xtext.java/src/org/eclipse/xtext/java/resource/JavaDerivedStateComputer.java

Line 115 in bc28645

switch (TypeDeclaration.kind(type.modifiers)) {

, should be updated somehow accordingly.

that is exactly where I am looking at. The "record" has to be handled there.

cdietrich · 2023-11-17T05:58:51Z

ping @szarnekow

rasifix · 2023-11-18T14:57:17Z

I was trying to fix this issue, but I have stumbled over additional problems. I have been experimenting with the domain language example:

created a record class
tried to reference it from the domain model

The record cannot be resolved. What I found out after a longer debugging session: JdtBasedTypeFactory constructs a ASTParser with JLS 3. This obviously does not support records, as records have not been part of JLS 3 (Java 5!?). Changing that to something more up to date at least fixes this issue. Why is this fixed to such a legacy version of Java?

Aside of that (shall I open a defect for it?), I do not get to the JavaDerivedStateComputer and verify that just adding "records" to the type switch fixes the issue. I would need some hints to further debug and test this.

cdietrich · 2023-11-18T15:08:52Z

i cannot tell you anything about why.
maybe @szarnekow can.
what happens if you bump that? (getJLSLatest)

rasifix · 2023-11-18T15:10:49Z

when I bump the version to e.g. AST.getJLSLatest() the Xtext properly resolves the reference to the record from the domain model DSL

cdietrich · 2023-11-18T15:11:38Z

with or without changes to the Type factories?

rasifix · 2023-11-18T15:13:15Z

all I did was bump the JLS version in JdtBasedTypeFactory#157; no other changes so far

cdietrich · 2023-11-18T15:14:38Z

I would have expected to find a similar switch there too

cdietrich · 2023-11-18T15:20:26Z

maybe its working cause
protected JvmDeclaredType createType(ITypeBinding typeBinding, String handleIdentifier, List<String> path, StringBuilder fqn) {
has no switch with default throw exception
as the other place has

szarnekow · 2023-11-18T15:41:22Z

I think back then there was no AST.getLastest available. We use much more recent JDT now, so that can be fixed

LorenzoBettini · 2024-04-23T12:53:49Z

Some updates:

by setting

	/**
	 * A cached AST parser that's reused by top-level type {@link #createType(IType) creation}.
	 */
	@SuppressWarnings("all")
	private final ASTParser parser = ASTParser.newParser(AST.getJLSLatest());

in org.eclipse.xtext.common.types.access.jdt.JdtBasedTypeFactory, running another instance of Eclipse, create a plug-in project with JavaSE-21, the Xtend file can seamlessly use Java records:

LorenzoBettini mentioned this issue Apr 23, 2024

Java 21 Masterplan #2686

Open

15 tasks

LorenzoBettini mentioned this issue May 14, 2024

Support for Java 21 #3037

Merged

LorenzoBettini closed this as completed in #3037 May 17, 2024

LorenzoBettini added this to the Release_2.35 milestone May 17, 2024

This was referenced May 17, 2024

fix java source lang record handling #3048

Merged

J21 Tests xtext/xtext-reference-projects#421

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Does Xtend work with java records? #2823

Does Xtend work with java records? #2823

tripleo1 commented Oct 18, 2023

cdietrich commented Oct 18, 2023

tripleo1 commented Oct 18, 2023

cdietrich commented Oct 18, 2023 •

edited

cdietrich commented Oct 18, 2023

cdietrich commented Oct 18, 2023

tripleo1 commented Oct 18, 2023

cdietrich commented Oct 18, 2023

cdietrich commented Oct 18, 2023

tripleo1 commented Oct 18, 2023

cdietrich commented Oct 18, 2023 •

edited

rasifix commented Nov 9, 2023

LorenzoBettini commented Nov 9, 2023

rasifix commented Nov 9, 2023

cdietrich commented Nov 9, 2023

LorenzoBettini commented Nov 9, 2023

cdietrich commented Nov 9, 2023

rasifix commented Nov 9, 2023

cdietrich commented Nov 17, 2023

rasifix commented Nov 18, 2023

cdietrich commented Nov 18, 2023 •

edited

rasifix commented Nov 18, 2023

cdietrich commented Nov 18, 2023 •

edited

rasifix commented Nov 18, 2023

cdietrich commented Nov 18, 2023

cdietrich commented Nov 18, 2023

szarnekow commented Nov 18, 2023

LorenzoBettini commented Apr 23, 2024

Does Xtend work with java records? #2823

Does Xtend work with java records? #2823

Comments

tripleo1 commented Oct 18, 2023

cdietrich commented Oct 18, 2023

tripleo1 commented Oct 18, 2023

cdietrich commented Oct 18, 2023 • edited

cdietrich commented Oct 18, 2023

cdietrich commented Oct 18, 2023

tripleo1 commented Oct 18, 2023

cdietrich commented Oct 18, 2023

cdietrich commented Oct 18, 2023

tripleo1 commented Oct 18, 2023

cdietrich commented Oct 18, 2023 • edited

rasifix commented Nov 9, 2023

LorenzoBettini commented Nov 9, 2023

rasifix commented Nov 9, 2023

cdietrich commented Nov 9, 2023

LorenzoBettini commented Nov 9, 2023

cdietrich commented Nov 9, 2023

rasifix commented Nov 9, 2023

cdietrich commented Nov 17, 2023

rasifix commented Nov 18, 2023

cdietrich commented Nov 18, 2023 • edited

rasifix commented Nov 18, 2023

cdietrich commented Nov 18, 2023 • edited

rasifix commented Nov 18, 2023

cdietrich commented Nov 18, 2023

cdietrich commented Nov 18, 2023

szarnekow commented Nov 18, 2023

LorenzoBettini commented Apr 23, 2024

cdietrich commented Oct 18, 2023 •

edited

cdietrich commented Oct 18, 2023 •

edited

cdietrich commented Nov 18, 2023 •

edited

cdietrich commented Nov 18, 2023 •

edited