Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the latest version of Node.js (8.12.0 or 11.0.0) #429

Closed
Luluno01 opened this issue Oct 27, 2018 · 3 comments
Closed

Add support for the latest version of Node.js (8.12.0 or 11.0.0) #429

Luluno01 opened this issue Oct 27, 2018 · 3 comments

Comments

@Luluno01
Copy link

I'm trying to build J2V8 with the latest Node.js as there is no official build with Node.js 8.x or above for Windows (x86-64). The followings are my building steps with some custom changes:

  1. Set Node.js version to 11.0.0 in build_system/build_settings.py
  2. Run nodejs git clone
  3. Modify the source code of Node.js manually and generate a diff file node.patches/11.0.0.diff
  4. Run build -i, select configuration 9 and enter nodejs to build Node.js (succeeded)
  5. Modify njs_libs in cmake/NodeJsUtils.cmake
  6. Run build -i, select configuration 9 and enter j2v8 (failed when linking)

The errors consist of already defined and unresolved external symbol _register_xxx. Sadly I have no I idea how to make the njs_libs list right :(.

Here is a repo that contains the changes I've made (last two commits).

@irbull
Copy link
Member

irbull commented Jan 11, 2019

Closing as a duplicate of #334.

@irbull irbull closed this as completed Jan 11, 2019
@irbull
Copy link
Member

irbull commented Jan 11, 2019

There is lots of information there. But in order to help move the project forward, I need to get a handle on the open issues. Thanks for reporting this, and letting me know that this is important!

@Luluno01
Copy link
Author

@irbull Thank you for your reply. If you are taking these two issues as duplicated, then you mean they are all about "update the core dependency of J2V8", right? I would like to be involved in such an interesting task, however, I have no sufficient related knowledge XD. Anyway, I am looking forward to the new version of J2V8 with the lasted Node.js runtime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants