Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An in-range update of eslint-plugin-react is breaking the build 🚨 #337

Open
greenkeeper bot opened this issue Dec 28, 2018 · 19 comments
Open

An in-range update of eslint-plugin-react is breaking the build 🚨 #337

greenkeeper bot opened this issue Dec 28, 2018 · 19 comments

Comments

@greenkeeper
Copy link
Contributor

greenkeeper bot commented Dec 28, 2018

The dependency eslint-plugin-react was updated from 7.11.1 to 7.12.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

eslint-plugin-react is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details
  • continuous-integration/appveyor/branch: Waiting for AppVeyor build to complete (Details).
  • continuous-integration/travis-ci/push: The Travis CI build failed (Details).

Release Notes for v7.12.0

Added

Fixed

Changed

Commits

The new version differs by 127 commits.

  • a83d65c Update CHANGELOG and bump version
  • 0c6160e [Dev Deps] update coveralls, babel-eslint, typescript
  • cd6c8e6 [Deps] update resolve
  • d2b5b73 Merge pull request #1828 from alexzherdev/1721-no-typos-create-class
  • e747459 [Tests] remove node 5/7/9, add node 11
  • b33ae84 Merge pull request #1098 from arian/createElement-display-test
  • 84be80a Merge pull request #1824 from alexzherdev/1762-jsx-max-depth-false-positive
  • a442067 Merge pull request #2029 from sstern6/issue1422
  • 7d07c37 Merge pull request #2032 from alexzherdev/jsx-fragments-message
  • 8c6a8e2 Merge pull request #2089 from jomasti/feature/support-react-forwardref-memo
  • 14451d4 Merge pull request #2085 from himynameisdave/issues/2083
  • 8be52c7 📝 Addresses CR comments
  • f7e3121 Merge branch 'master' of https://github.com/yannickcr/eslint-plugin-react into issues/2083
  • 77e3fd0 Merge pull request #2090 from JBallin/no-method-set-state-docs-url
  • 7da9e0d Fix noMethodSetState docsUrl's

There are 127 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Dec 28, 2018

After pinning to 7.11.1 your tests are still failing. The reported issue might not affect your project. These imprecisions are caused by inconsistent test results.

@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Jan 1, 2019

Your tests are still failing with this version. Compare changes

Release Notes for v7.12.1

Fixed

Changed

Commits

The new version differs by 9 commits.

  • 0202de3 Update CHANGELOG and bump version
  • 6f7cb51 [Tests] fix linter
  • 695e534 [Fix] jsx-wrap-multilines: avoid crash when no trailing newline
  • 146d8d1 [Fix] jsx-max-depth: avoid a crash
  • dfeeb81 Merge pull request #2099 from jomasti/issue-2094
  • 55e5fc1 Fix false positives inside lifecycle methods
  • 254a84a Merge pull request #2098 from jomasti/issue-2096
  • 72982f6 Fix no-unused-state crash
  • 835fc05 Fix CHANGELOG.md

See the full diff

@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Jan 3, 2019

Your tests are still failing with this version. Compare changes

Release Notes for v7.12.2

Fixed

Commits

The new version differs by 5 commits.

  • c93cbc6 Update CHANGELOG and bump version
  • e71feb5 [Fix] forbid-prop-types: fix crash with propWrapper check on MemberExpressions
  • 11a66c0 Merge pull request #2103 from yoyo837/patch-1
  • e9cfc16 Link does not end with '.'
  • 4da90ea [Fix] prop-types: avoid crash on used prevProps

See the full diff

@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Jan 16, 2019

Your tests are still failing with this version. Compare changes

Release Notes for v7.12.3

Fixed

Changed

Commits

The new version differs by 14 commits.

  • 2f5cec9 Update CHANGELOG and bump version
  • 096161a Merge pull request #2120 from jomasti/issue-2119
  • 9d3955a Prevent crash of jsx-indent rule
  • 230c7e0 Merge pull request #2117 from haideralsh/patch-1
  • b4b0e72 fix: add a missing in the JSON settings
  • d2aa260 Merge pull request #2115 from drx/class_body_prop_types
  • 41974e5 Fix propType detection inside class bodies
  • 40f2565 [Docs] update README to document React version detection
  • dd0757f Merge pull request #2113 from alexzherdev/2112-fix-self-closing-fragments
  • e997f6c [Fix] avoid crashing on self-closing fragments
  • b48b479 Merge pull request #2111 from drx/prop_types_class_properties
  • e15bafa [Fix] no-unused-prop-types: fix issue with propTypes misclassifying props
  • a86b339 Merge pull request #2109 from jomasti/issue-2105
  • 5f9863e Fix display-name false positive for React.memo

See the full diff

@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Jan 17, 2019

Your tests are still failing with this version. Compare changes

Release Notes for v7.12.4

Fixed

Changed

Commits

The new version differs by 10 commits.

  • 433cc3f Update CHANGELOG and bump version
  • 536bc35 [Tests] prop-types: add case from #2134
  • df7ffc1 [Tests] no-typos: test case from #2136
  • c7e5f38 [Tests] improve version detection tests.
  • 2dd2277 [Tests] prop-types: add now-passing test case
  • 84652b6 [Fix] no-unused-prop-types: avoid a crash
  • 58ed9e9 [Fix] prop-types: avoid further crashes from nonexistent nodes in unusedPropTypes
  • 7f7b96d [Fix] prop-types: Read name of callee object.
  • 5fc50aa [Fix] Ignore reassignments when matching props declarations with components
  • ba80a4c [Fix] Detect components with return statement in switch/case

See the full diff

@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented May 3, 2019

Your tests are still failing with this version. Compare changes

Commits

The new version differs by 74 commits.

  • f39829f Update CHANGELOG and bump version
  • 9e81dde [Deps] update jsx-ast-utils, resolve
  • e73a692 Merge pull request #2256 from mateuszsokola/master
  • b5fc9bf [fix] jsx-props-no-multi-spaces: support generic components (ts)
  • 8bd3837 Fix Node 4 compatibility
  • 005dad3 Revert "Replace mocha by jest"
  • 6e4f43e Replace mocha by jest
  • 09f580c Replace typescript-eslint-parser by @typescript-eslint/parser
  • 861fdef [fix] prop-types: fix case with destructuring and defualt param
  • 9fbd037 Fix ESLint 6 compat by providing parser as absolute path to RuleTester
  • 8041075 Fix jsx-curly-brace-presence schema defaults
  • 9cec705 Add next ESLint version to Travis
  • 0d4725e Add Node 12 and remove Node 4/6 from Travis
  • 9192ec3 Update devDependencies
  • d5d2e82 Merge pull request #2250 from guliashvili/master

There are 74 commits in total.

See the full diff

@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Jun 23, 2019

Your tests are still failing with this version. Compare changes

Release Notes for v7.14.0

Added

Fixed

  • Fix no-did-mount-set-state and no-did-update-set-state to handle cDU and cDM defined as class properties (#1595 @jaaberg)
  • Fix sort-prop-types cash when a shape PropType is defined in a variable (#1749 @alexzherdev)
  • Fix no-unused-state false positive when using state of non-lifecycle method (#2274 @golopot)
  • Fix static-property-placement false positive when accessing static property inside method (#2283 @dmason30)
  • Fix prop-type detection for annotated props with default value (#2298 @yannickcr)

Changed

Commits

The new version differs by 68 commits.

  • dfaa92f Update CHANGELOG and bump version
  • c52b61b Merge pull request #2316 from kaykayehnn/jsx-key-fragments
  • 8db631b [Fix] Fix detection of annotated props with default value
  • bbebefd [Tests] Remove AppVeyor
  • 0d49f5a [New] Add ESLint ^6.0.0 as valid peerDependency
  • 0364ed2 Fix formatting issues
  • 7c1abed Add checkFragmentShorthand option
  • ed04c2f Fix tests in eslint < 5
  • 0d1aaf8 Handle fragments in jsx-key
  • 7d449a9 [New] jsx-sort-props: Change reported range to only the identifier
  • 1e102f0 Change reported range to only the identifier
  • e6b4c33 Merge pull request #2301 from golopot/fix-cached-props-2
  • 9a63e19 Immediately destructure out propVariables rather than using it as a namespace
  • 3a1a0d1 Apply suggestion: replace mutation with Object.assign
  • 89b8143 Apply suggestion: replace concat([a]) with concat(a)

There are 68 commits in total.

See the full diff

@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Jun 24, 2019

Your tests are still failing with this version. Compare changes

Release Notes for v7.14.1

Fixed

  • Fix prop-types crash on multiple destructuring (#2319 @golopot)
Commits

The new version differs by 3 commits.

  • 62255af Update CHANGELOG and bump version
  • 655eb01 Merge pull request #2320 from golopot/issue-2319
  • 9639d82 [Fix] prop-types: fix crash on multiple destructuring

See the full diff

@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Jun 24, 2019

Your tests are still failing with this version. Compare changes

Release Notes for v7.14.2

Fixed

Commits

The new version differs by 2 commits.

  • 8432e5e Update CHANGELOG and bump version
  • 057f1db [Fix] : fix crash on for...of destructuring

See the full diff

@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Jul 22, 2019

Your tests are still failing with this version. Compare changes

Release Notes for v7.14.3

Fixed

  • Fix prop-types to ignore validation when Flow indexers are used (#2330 @yannickcr)
  • Fix error being thrown after the first warning when react version cannot be detected (#2336 @abhishekdev)
  • Fix component detection when memo and forwardRef are used together (#2349 @yannickcr)

Changed

Commits

The new version differs by 14 commits.

  • 47c4c8b Update CHANGELOG and bump version
  • 98d4bf3 Fix component detection when memo and forwardRef are used together
  • fc70077 Merge pull request #2354 from golopot/patch-1
  • f2891d9 [docs] remove outdated docs for no-unused-prop-types
  • 49343d4 [meta] add github sponsorship
  • 562e441 Add Tidelift badge to README
  • b684e87 Add SECURITY file
  • 22a3740 Add FUNDING file
  • e835aaf add note about global installs being deprecated
  • 0215c38 Merge pull request #2336 from abhishekdev/handle-react-detect-errors
  • 8fbf50c version detection: Do not throw a raw error after the first warning
  • f59e927 version detection: Add tests
  • d6832d6 Fix new required import order
  • bc67d42 Fix prop-types to ignore validation when Flow indexers are used

See the full diff

@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Oct 1, 2019

Your tests are still failing with this version. Compare changes

Commits

The new version differs by 30 commits.

  • b45219a Update CHANGELOG and bump version
  • a01198f [Dev Deps] update eslint-config-airbnb-base, eslint-plugin-import, sinon, typescript
  • ab77870 [Deps] update jsx-ast-utils, resolve
  • 32e27b7 [Fix] jsx-indent: Fix false positive when a jsx element is the last statement within a do expression (with tests)
  • 628a4a0 [fix] jsx-curly-brace-presence: fix jsx tags in braces
  • 3124ce0 [Docs] no-access-state-in-setstate: update grammar
  • 4a05fa2 [fix] display-name: Fix false positives
  • c6521ad Change istanbul output directory to ./coverage (default)
  • 5970651 [new] jsx-handler-name: allow false to disable eventHandlerPrefix/eventHandlerPropPrefix
  • 489ced3 [refactor] jsx-curly-braces-presence, jsx-one-expression-per-line, no-danger-with-children: add isWhiteSpaces to lib/util/jsx
  • 9b2db61 [fix] jsx-curly-brace-presence: report unnecessary curly braces with children on next line
  • 781bfff [new] sort-comp: add static-variables grouping
  • 7ccff10 [New] add jsx-no-useless-fragment rule
  • 66725bc [Fix] no-unused-prop-types: false positive with callback
  • 3c72a49 [eslint] disable some options and manually fix valid-jsdoc

There are 30 commits in total.

See the full diff

@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Oct 1, 2019

Your tests are still failing with this version. Compare changes

Commits

The new version differs by 4 commits.

  • e336aef Update CHANGELOG and bump version
  • 04fbe74 [Fix] jsx-curly-brace-presence: bail out checks when JSXElements are passed as props
  • 20cc016 [Docs] prefer-es6-class: Fix typos
  • feba507 [Fix] jsx-curly-brace-presence: bail out on JSX inside props, for now

See the full diff

@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Oct 4, 2019

Your tests are still failing with this version. Compare changes

Commits

The new version differs by 6 commits.

  • fb3210b Update CHANGELOG and bump version
  • 6011505 [new] jsx-sort-default-props: make rule fixable
  • 6f14e16 [fix] jsx-no-useless-fragment: use array-includes over .includes for back compat
  • a1dee7c [fix] jsx-curly-brace-presence: allow necessary white-space literal
  • d7d2a01 [Fix] jsx-curly-brace-presence: warns incorrectly on trailing whitespace
  • c153a86 [Fix] no-unused-prop-types: false positive when nested destructuring

See the full diff

@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Nov 29, 2019

Your tests are still failing with this version. Compare changes

Release Notes for v7.17.0

Added

Fixed

Changed

Commits

The new version differs by 26 commits.

  • 027ebd9 Update CHANGELOG and bump version
  • 89911de [Deps] update jsx-ast-utils, object.fromentries, resolve
  • cfef664 [Dev Deps] update @types/eslint, @types/estree, @types/node, coveralls, typescript
  • d3b5d71 [New] jsx-no-target-blank: add allowReferrer option
  • 83ac4c0 [eslint] fix func-names and change object-shorthand to 'always'
  • 225b433 [Docs] jsx-first-prop-new-line: Fix documentation formatting
  • 62df1dd [Docs] prop-types: Update 'skipUndeclared' in rule options
  • 87d4cab [Docs] jsx-first-prop-new-line: fix wrong rule name
  • 55b605f [Fix] sort-prop-types, jsx-sort-default-props: disable broken autofix
  • 71c7d01 [Tests] temporarily pin eslint 6 tests to v6.6
  • 8093565 [New] jsx-handler-names: add checkLocalVariables option
  • 5be539b [Fix] no-typos: improve report location
  • d9d2193 [eslint] enable eslint-plugin-eslint-plugin
  • 39e4396 [Docs] jsx-props-no-multi-spaces: suggest using core rule instead
  • 9e4ad21 [Docs] jsx-first-prop-new-line: add rule options

There are 26 commits in total.

See the full diff

@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Feb 1, 2020

Your tests are still failing with this version. Compare changes

Commits

The new version differs by 32 commits.

  • 000d6b8 Update CHANGELOG and bump version
  • ffdf69a [Fix] jsx-indent: Does not check indents for JSXText
  • 182b045 [Docs] use markdown-magic to automatically sort all rules alphabetically
  • 45b9d32 [Docs] jsx-props-no-spreading: fix typo to use correct rule
  • f9aee94 [Fix] jsx-props-no-spreading: add support for namespaced jsx components
  • e69b113 [Fix] jsx-no-target-blank: allow rel to be an expression
  • fc6e406 [meta] fix changelog date
  • 50df78f [Fix] sort-comp: | isn’t a valid regex flag; u and s are
  • a7f6a8b [Tests] on node v13
  • 6a45142 Update CHANGELOG and bump version
  • d9e4941 [Deps] update array-includes, object.entries, object.fromentries, object.values, resolve
  • d1dc277 [Fix] no-unused-prop-types, no-unused-state: fix false positives when using TS type assertions
  • 99cea84 [New] function-component-definition: Enforce a specific function type for function components
  • c234d0f [Docs] no-render-return-value: Fix title
  • 5fac02c [Fix] jsx-pascal-case: false negative with namespacing

There are 32 commits in total.

See the full diff

@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Feb 2, 2020

Your tests are still failing with this version. Compare changes

Commits

The new version differs by 2 commits.

  • 37c4ef3 Update CHANGELOG and bump version
  • 3da6eb3 [Fix] jsx-indent: avoid a crash on non-string literals

See the full diff

@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Feb 3, 2020

Your tests are still failing with this version. Compare changes

Commits

The new version differs by 2 commits.

  • 0a717a5 Update CHANGELOG and bump version
  • 8b576be [Fix] jsx-indent: don't check literals not within JSX

See the full diff

@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Mar 6, 2020

Your tests are still failing with this version. Compare changes

Commits

The new version differs by 14 commits.

  • e2ed536 Update CHANGELOG and bump version
  • 5959b5f [fix] prefer-stateless-function: avoid crash on ts empty constructor
  • e231f44 [tests] no-unescaped-entities: skip test cases that are now parsing errors in acorn-jsx@5.2.0
  • 434b45f [Dev Deps] update @types/eslint, @types/estree, @types/node, eslint-plugin-eslint-plugin, eslint-plugin-import, typescript
  • a917dda [Deps] update resolve, xregexp
  • 09608cc [Fix] no-adjacent-inline-elements: avoid a crash
  • b833535 [Fix] no-unused-prop-types: Change the reporting to point to a more accurate node
  • edc5fe2 [New] style-prop-object: Add allow option
  • 9b5d6aa [Fix] self-closing-comp: consider JSXMemberExpression as component too
  • 598277e [New] jsx-pascal-case: Support unicode characters
  • 43e466c [readme] Small visual inconsistency
  • 03edb68 [docs] add react/ prefix to rule name, for consistency
  • b517b9e [Fix] no-unused-prop-types: make markPropTypesAsUsed work with TSEmptyBodyFunctionExpression AST node
  • 66c0d66 [Fix] displayName (but really, propTypes detection): do not crash on empty flow type spreads

See the full diff

@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented May 13, 2020

Your tests are still failing with this version. Compare changes

Release Notes for v7.20.0

Added

Fixed

Docs

Changed

  • [Deps] Move "semver" to devDependencies (#2595 @rajivshah3)
  • [eslint] remove operator-linebreak override (#2578 @golopot)
  • [Tests] button-has-type: ensure no mistakenly allowed identifiers named button/submit/reset (#2625 @golopot)
  • [Tests] displayName: add a test case (#2593 @golopot)
  • [Dev Deps] update @types/eslint, @types/estree, @types/node, @typescript-eslint/parser, coveralls, eslint-config-airbnb-base, eslint-plugin-import, typescript
Commits

The new version differs by 27 commits.

  • 25bf6cc Update CHANGELOG and bump version
  • 2598b1e [Dev Deps] update @types/eslint, @types/estree, @types/node, @typescript-eslint/parser, coveralls, eslint-config-airbnb-base, eslint-plugin-import, typescript
  • f94d851 [Fix] jsx-sort-props: only use localeCompare when case is ignored
  • c481a26 [Docs] Clean up examples in rule docs
  • 88d404d [eslint] remove operator-linebreak override
  • 304590a Merge pull request #2635 from ljharb/eslint7
  • 35030a0 [Tests] fix mistaken error property and add output property
  • 906b474 [New] support eslint v7
  • d66f467 [Fix] jsx-key: add a failing test case for optional chaining
  • da7a045 [Fix] no-unused-state: handle optional chaining
  • 9861469 [New] forbid-component-props/forbid-dom-props: Allow a custom message with forbid props
  • ab28224 [Fix] jsx-pascal-case: Do not consider namespaces when checking for DOM
  • 25b1936 [Fix] jsx-curly-spacing, jsx-no-bind, usedPropTypes util: avoid node.start and node.end
  • db4e471 [readme] Add Rules of Hooks to Other useful plugins section
  • b9d2eb5 [Fix] jsx-no-target-blank: allow no-referrer without noopener by default

There are 27 commits in total.

See the full diff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

0 participants