You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
) run the tests against schema/migration directories inside the source tree. The migration create commands in tests will create new files in the source tree that are left in place (and ignored with https://github.com/edgedb/edgedb-cli/blob/master/tests/.gitignore)
To make things work if the tests are run more than once, at the start of the tests they attempt to delete the migrations.
This makes them fragile, though, in combination with putting hashes in the file names now. I've been getting failures on modified3_interactive because, at least locally for me, we now generate 00002-m1nnddt.edgeql as the second migration file, which isn't what the test expects.
This never shows up in CI, because it only runs the tests once.
I think the correct approach is to copy the folders into the a tmp directory.
The text was updated successfully, but these errors were encountered:
The migration tests (such as
edgedb-cli/tests/func/migrations.rs
Lines 574 to 577 in 9df25ac
migration create
commands in tests will create new files in the source tree that are left in place (and ignored with https://github.com/edgedb/edgedb-cli/blob/master/tests/.gitignore)To make things work if the tests are run more than once, at the start of the tests they attempt to delete the migrations.
This makes them fragile, though, in combination with putting hashes in the file names now. I've been getting failures on
modified3_interactive
because, at least locally for me, we now generate00002-m1nnddt.edgeql
as the second migration file, which isn't what the test expects.This never shows up in CI, because it only runs the tests once.
I think the correct approach is to copy the folders into the a tmp directory.
The text was updated successfully, but these errors were encountered: