Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brightness setting for text/background #1917

Closed
c0ldw1nd opened this issue Mar 1, 2023 · 5 comments
Closed

Brightness setting for text/background #1917

c0ldw1nd opened this issue Mar 1, 2023 · 5 comments

Comments

@c0ldw1nd
Copy link

c0ldw1nd commented Mar 1, 2023

I really like the brightness setting in the Amazon Kindle Windows app.

White text/background is gradually greyified as you move the slider.

Would it be possible to implement and add this feature to Thorium Reader?

grafik

grafik
grafik

grafik
grafik

@danielweck
Copy link
Member

This is a nice feature (I personally use it on my screens and readers), but based on my knowledge of the current software architecture, I would say that this functionality would require significant evolutions in how colour themes / schemes are implemented in Thorium, so I wouldn't hold my breath.
In my opinion a higher development priority would be to dark-ify the main library window (currently only the reader window supports a night mode), and whilst we're at it also support the sepia palette.
We are also aware of low-contrast issues which we will as soon as possible.

@danielweck
Copy link
Member

related:
#1915
#1600
#577

@c0ldw1nd
Copy link
Author

c0ldw1nd commented Mar 3, 2023

@danielweck
Nice you like and use it too.
Thought so, it wouldn't be easy to implement.
Yeah, it's a nice feature but not a MUST.
Surely your priority planning is more important than some random guy asking for a new feature.
Would be great if I could use it some day in the future.

@danielweck
Copy link
Member

Surely your priority planning is more important than some random guy asking for a new feature.

Thorium's list of priorities are largely influenced by user needs and feedback, so please never hesitate to post feature requests or suggestions here again!
But yes, it does ultimately come down to how much a small development team can do given finite time and budget :)

@danielweck
Copy link
Member

Thorium 3 will introduce colour themes ... not quite like a linear slider for arbitrary background "brightness", but as good as it will get in Thorium in the foreseeable future. I am closing this issue as I expect new feature requests / suggestions will emerge based on the refactored GUI experience

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants