Incorrect interpretation of the OPDS 2 indirect acquisition feature.

[llemeurfr]

The way Thorium is programmed, the behavior of acquisition links is constrained by the content type of the link target: in

thorium-reader/src/main/converter/opds.ts

Line 326 in dbfc221

const acquisitionLinkView = this.convertFilterLinksToView(baseUrl, r2OpdsPublication.Links, {

we see that a link of type acquisition or acquisition/open-access is active only if the content type is one of those listed in

thorium-reader/src/main/converter/opds.ts

Line 44 in dbfc221

const supportedFileTypeLinkArray = [

HTML is not one of them.

This constraint does not exist for links of type acquisition/buy or acquisition/subscribe.
And the label of the button is associated with the acquisition type (acquisition/buy => "Buy this book").

Now here is the issue: A bookseller provides a subscription based service. He wants to provide an ODPS catalog to his users, but he cannot provide OPDS Authentication at this time.
The solution I proposed is to generate an OPDS catalog with links to individual pages of his Web site, where users can authenticate, download an LCP license and side-load the license into Thorium Reader.

The feed should be like

"publications": [
    {
      "metadata": {
        "@type": "http://schema.org/Book",
        "title": "xxxx",
        "author": "xxxx",
        "identifier": "urn:isbn:xxxx",
        "language": "en"
      },
      "links": [
        {
          "rel": "http://opds-spec.org/acquisition",
          "href": "//link to the web page corresponding to the book//",
          "type": "text/html"
        }
      ],
      "images": [
        {
          "href": "https://edrlab.org/public/feed/moby-dick/cover.jpg",
          "type": "image/jpeg",
          "height": 499,
          "width": 348
        }
      ]
    }
]

But the rel = acquisition does not give what is expected, the button does not appear.
I must use rel = acquisition/buy, but the label of the button is not what I expect.

I would like this use-case to be supported and every type of acquisition link be compatible with an html page as a target. The label could be "Import (Web)" if the acquisition link is of type acquisition.

I also see a bug with acquisition/borrow, whatever content type I use: I get a blank page and I must quit Thorium.
You can test with this test OPDS feed -> https://edrlab.org/public/feed/test/opds-feed.json