Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localisation update, translations for Thorium 3.0 #2219

Open
llemeurfr opened this issue May 17, 2024 · 53 comments
Open

Localisation update, translations for Thorium 3.0 #2219

llemeurfr opened this issue May 17, 2024 · 53 comments

Comments

@llemeurfr
Copy link
Contributor

Dear contributors, Thorium 3.0 will be released around May 20. The new version proposes a major update of the User Interface; several existing labels have been shortened and new features (mainly annotations) require new labels.

Localization is now eased by the use of GitLocalized, a simple translation tool. As usual, the English locale is the reference.

Please go to https://gitlocalize.com/repo/9626 and Sign in with Github. Send us you Github ID so that we can add you as "translator".

Choose your preferred language and open the json file in the interface. On the left side you'll see the English labels, on the right translated labels. Please check the existing translations. News labels will be blank in right cells, please fill them. There is a "comments" feature if a discussion is required on certain terms.

When it is done, please Create a Review Request (top yellow button).

Thorium Localization (l10n) language translations

Information and discussions about localization and language translation process can be found in the Thorium wiki l10n dedicated page

Actual known contributors are :

@horus68
@milliet
@martinpub
@Modeo147
@naglis
@jacoporinaldi
@peaceroad
@panaC
@nvdaes
@HadrienGardeur
@tofi86
@terhol-celia
@maitreya2019
@cary-rowen
@ThanatosDi
@georgegach
@sukiletxe

@gautierchomel
Copy link
Member

@izorba

@ThanatosDi
Copy link
Contributor

ThanatosDi commented May 17, 2024

@llemeurfr
I already Sign in with Github
https://gitlocalize.com/users/ThanatosDi

@naglis
Copy link
Contributor

naglis commented May 17, 2024

@danielweck
Copy link
Member

@naglis @ThanatosDi you are now team "translators" :)
Welcome and thank you

@martinpub
Copy link
Contributor

Thanks for the localisation call! For this round, @jonaslil will update the Swedish locale.

@milliet
Copy link
Contributor

milliet commented May 17, 2024 via email

@izorba
Copy link
Contributor

izorba commented May 17, 2024

https://gr.linkedin.com/in/zorbaioanna
Hi! I have started working, but I am not in the translators list
Can you help me?
Thanks!

@nvdaes
Copy link
Sponsor Contributor

nvdaes commented May 17, 2024

Hello: You can add me for Spanish.
My GitHub ID is: 15809252

@danielweck
Copy link
Member

@nvdaes @izorba @jonaslil you are now team "translators" :)
Welcome and thank you

@milliet first you need to log into GitLocalize :)

@horus68
Copy link
Contributor

horus68 commented May 17, 2024

@danielweck Can you please update the wiki page https://github.com/edrlab/thorium-reader/wiki/Localization-(l10n)-language-translations to include the link to the Gitlocalize repo https://gitlocalize.com/repo/9626 ?

@jonaslil
Copy link
Contributor

Thanks @danielweck, working on it.

By when should the translation be submitted to be included in version 3.0?

@nvdaes
Copy link
Sponsor Contributor

nvdaes commented May 17, 2024

@danielweck , I've finished the spanish translation, though in the GitLocalize webpage appears 78%. Perhaps some words are equal.
Annotations is an amazing feature. Thanks for your had and nice work.

@horus68
Copy link
Contributor

horus68 commented May 17, 2024

Something broken... all translations updates gone. I had 100% done, same as Slovenian... now it went down again to 46%
My already submitted translation also was deleted! (error 500 when accessing it on Gitlocalize) :(

Maybe the language files were updated on the GITHUB project directly from your local computer?
I believe that only the master english language files should be updated, the translations should be updated form the GITLOCALIZE project using their own PR creator

@danielweck
Copy link
Member

interesting ... there are new commits in the develop branch, and GitLocalize synchronizes its state with GitHub so maybe that's the cause of the refresh. I'll see if anything was lost, give me a minute...

@milliet
Copy link
Contributor

milliet commented May 17, 2024 via email

@danielweck
Copy link
Member

To those of you who submitted your translation as "Review Request", I am horrified and mortified to discover that your work seems to have vanished from GitLocalize!! I am posting on their issue tracker right now, trying to figure out if this is an exceptional bug, or a "normal" part of the workflow which means that whenever changes are pushed to the develop branch (even if only a minor update of the JSON locales) we must approve ALL the Review Requests before pushing our code, otherwise GitLocalize nukes existing pending work ... I know this sounds stupid, given that the system is supposed to handle conflict and help users / translators identify diverged strings and  merge resolutions.
I will post screenshots below to show you what I see in GitLocalize, as an admin...

@danielweck
Copy link
Member

Even with frequent updates to your project, GitLocalize keeps localization stress-free.

https://docs.gitlocalize.com/about.html

@danielweck
Copy link
Member

@nvdaes your Spanish data was still in GitLocalize as a pending / open Review Request, so I quickly created a Pull Request here in GitHub #2231

@milliet
Copy link
Contributor

milliet commented May 17, 2024 via email

@danielweck
Copy link
Member

@nvdaes your Spanish translation is indeed at 78%, in fact I see empty strings in the GitLocalize user interface. I hope this is not too hard with your screen reader: https://gitlocalize.com/repo/9626/es/src/resources/locales/en.json

@danielweck
Copy link
Member

danielweck commented May 17, 2024

So, I went back to all the notification emails I received from GitLocalize (because their website admin panel doesn't show this) and I found the following:

@danielweck
Copy link
Member

I posted my feedback in the GitLocalize GitHub issue tracker: gitlocalize/feedback#138

@danielweck
Copy link
Member

Looking at Thorium's JSON locales changelog timeline (timestamps), I am now fairly certain that the reason why @nvdaes Spanish data survived is because she posted her work after we pushed changes, all other translators posted their Review Request before:
b3e2d8c#diff-da7119d1c8c008d685d71dd864febae06da76c518a53683034f8ec52fcece6d8

@danielweck
Copy link
Member

@llemeurfr @panaC if indeed the issue here is that modifying any JSON locale other than the reference en.json causes data loss on GitLocalize servers (for pending Review Requests that are not yet converted to GitHub Pull Requests, at least from what I can deduct)...then we have a big problem because as previously discussed, the JSON generated by GitLocalize is not formatted as per our existing conventions (not just indentation, but also empty strings that disappear totally ... maybe even lack of alphanumerical recursive key sorting), which breaks our own code diff tracking process. Our expected workflow was to continue as before: "fork" the translator's PR to normalise the contributed JSON and merge into the develop branch once fully verified. Same with new locales, except extra work / plumbing in the codebase.
One solution is of course for us to modify our existing conventions in order to align with GitLocalize expectations: never modify JSON locales other than en.json, match JSON indentation by tweaking our script / tools, also handle missing keys as empty strings (I suspect alphanumerical key sorting will not be enforced by GitLocalize either, so that's that).
My gut instinct is that competitor tools will pose similar problems, or at least impose similar constraints. We decided to go with GitLocalize for its ease-of-use and minimalist feature set, I remain confident that this is a good choice in that respect. I am now waiting for their response, just to make sure my assumptions are correct.

@nvdaes
Copy link
Sponsor Contributor

nvdaes commented May 18, 2024

@danielweck , I tried to translate all the strings, but for any reason, perhaps because I hadn't never used this platform (Gitlocalize), I see that some of them are not preserved. But when a PR is in review translators cannot edit it.
Can you please change the state of the PR to finish the spanish translation?
Also, if you can tell me if there is some visual or alignment difference to navigate directly to strings which need to be translated, I'd try to use my screen reader to do it, since now it has the ability to navigate to same or different style text. I don't know if this will work in this table.
Another alternative is if Poedit can be used, since untranslated strings meaybe grouped at the start of the file.
Thanks.

@cary-rowen
Copy link
Contributor

Hi @danielweck

https://gitlocalize.com/users/cary-rowen

Please help me register as a Simplified Chinese translator.

Thanks

@ThanatosDi
Copy link
Contributor

ThanatosDi commented May 18, 2024

@danielweck So, we need to re translation or waiting GitLocalize answer feedback?
Will it affect the version 3.0 update schedule?

@danielweck
Copy link
Member

@cary-rowen I added you to the team as a "translator". Welcome and thank you for your past and future contributions!

@danielweck
Copy link
Member

@ThanatosDi there is a "download" button in GitLocalize user interface, so a manual backup is possible. Now that we know about the GitLocalize data loss bug, we are going to be careful merging JSON locale files into the develop branch!

Screenshot 2024-05-18 at 19 13 50

danielweck pushed a commit that referenced this issue May 21, 2024
Co-authored-by: Ioanna Zorba (Zormpa) <izorba@uoi.gr>
@danielweck
Copy link
Member

@naglis the "translation memory" suggestions seem to only appear when a translatable label located in the right column (i.e. your language) is missing (it default to English and is displayed in pale silver). As soon as you place your cursor inside the text edit field, then the suggested memorised strings appear at the bottom of the page.
Here is a screenshot with Spanish:

Screenshot 2024-05-21 at 11 12 31

danielweck pushed a commit that referenced this issue May 21, 2024
Co-authored-by: Modeo147 <yakobi656@gmail.com>
panaC pushed a commit that referenced this issue May 22, 2024
Co-authored-by: Modeo147 <yakobi656@gmail.com>
danielweck pushed a commit that referenced this issue May 22, 2024
Co-authored-by: k_taka <peaceroad@gmail.com>
danielweck pushed a commit that referenced this issue May 22, 2024
Co-authored-by: Horus68 <pauloizidoro@gmail.com>
danielweck pushed a commit that referenced this issue May 22, 2024
Co-authored-by: jonaslil <jonas.lillqvist@gmail.com>
danielweck pushed a commit that referenced this issue May 23, 2024
Co-authored-by: Miia Kirsi <miia.kirsi@celia.fi>
Co-authored-by: jonaslil <jonas.lillqvist@gmail.com>
Co-authored-by: KirsiYl <kirsi.ylanne@celia.fi>
danielweck pushed a commit that referenced this issue May 24, 2024
Co-authored-by: Naglis Jonaitis <naglis@mailbox.org>
danielweck pushed a commit that referenced this issue May 26, 2024
Co-authored-by: Gautier Chomel <gautier.chomel@gmail.com>
Co-authored-by: Noelia Ruiz Martínez <nrm1977@gmail.com>
@gautierchomel
Copy link
Member

Hello, we have one week extra to proceed to translations!

We are missing:

@gautierchomel
Copy link
Member

Also, we'll update the wiki page for all translators to highlight your work better.

To that end we're collecting words in Localization wiki #2369.

Alternatively, you can drop us a message by email.

@ddfreiling
Copy link
Contributor

@gautierchomel Thanks for the bat signal, I'd love to complete the Danish translation for Thorium 3!
I have logged into GitLocalize on this GitHub ID.

@gautierchomel
Copy link
Member

@gautierchomel Thanks for the bat signal, I'd love to complete the Danish translation for Thorium 3!
I have logged into GitLocalize on this GitHub ID.

You are now a translator and moderator for Danish.

danielweck pushed a commit that referenced this issue May 27, 2024
Co-authored-by: L. Le Meur <laurent.lemeur@edrlab.org>
danielweck pushed a commit that referenced this issue May 29, 2024
Co-authored-by: Naglis Jonaitis <naglis@mailbox.org>
danielweck pushed a commit that referenced this issue May 29, 2024
Co-authored-by: Miia Kirsi <miia.kirsi@celia.fi>
danielweck pushed a commit that referenced this issue May 29, 2024
Co-authored-by: jonaslil <jonas.lillqvist@gmail.com>
llemeurfr pushed a commit that referenced this issue May 29, 2024
Co-authored-by: xFizox <jan.bfizovic@gmail.com>
llemeurfr pushed a commit that referenced this issue May 29, 2024
Co-authored-by: Ioanna Zorba (Zormpa) <izorba@uoi.gr>
llemeurfr pushed a commit that referenced this issue May 29, 2024
Co-authored-by: Daniel Freiling <dfg@nota.dk>
danielweck pushed a commit that referenced this issue May 29, 2024
Co-authored-by: KirsiYl <kirsi.ylanne@celia.fi>
danielweck pushed a commit that referenced this issue May 30, 2024
Co-authored-by: Horus68 <pauloizidoro@gmail.com>
Co-authored-by: mt-gitlocalize <mt@gitlocalize.com>
danielweck pushed a commit that referenced this issue May 30, 2024
Co-authored-by: k_taka <peaceroad@gmail.com>
danielweck pushed a commit that referenced this issue Jun 1, 2024
Co-authored-by: 古丁丁 <yykkold55tw@gmail.com>
danielweck pushed a commit that referenced this issue Jun 1, 2024
Co-authored-by: Tobias Fischer <tobias.carl.fischer@gmail.com>
danielweck pushed a commit that referenced this issue Jun 1, 2024
Co-authored-by: Adecabo9 <ade.cabo@demarque.com>
danielweck pushed a commit that referenced this issue Jun 1, 2024
Co-authored-by: Pedro Milliet <pedro.milliet@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests