GUI meta-issue (multiple problems reported) => need to verify all addressed in develop branch

[danielweck]

• [New GUI] Comparison Figma Designs/Alpha – Home + Settings – Dark mode #2190
• [New GUI] Comparison Figma Designs/Alpha – Reading screen – Light mode #2189
• [New GUI] Comparison Figma Designs/Alpha – Reading screen – Dark mode  #2192
• [New GUI] Comparison Figma Designs/Alpha – PublicationInfo – Dark mode #2191
• [New GUI] Comparison Figma Designs/Alpha – Catalogs – Light mode #2186  #2187
• [New GUI] Comparison Figma Designs/Alpha – All books – Light mode #2186

[danielweck]

From now on, please let's file granular issues with actionable problem descriptions, and let's create one PR per problem solved ... otherwise code reviewers and patch testers have a really hard time validating proposed changes :)
Thank you all for the hard work though! We just need to break down large chunks into more digestable snacks ;)

[panaC]

The issue with css it's when you patch the head the tail breaks :)
It's not so easy

[danielweck]

well, in principle CSS modules solve this, or any component-level scoping mechanism ... but composability and reusable styles mean that with raw CSS, selectors and cascade leak all over the place very quickly when scaling up the number of components :)
(even worse when retrofitting, as we are doing now)
Libraries like Vanilla Extract (or more modern incarnations) help compose styles, strict build-time checks with no runtime penalty (unlike css-in-js)...but this would have been a huge undertaking in Thorium, even bigger than this one.
Tailwind solves DX problems in its own way, but also a complete massive refactor in Thorium (not realistic)
So, here we are ... ;D

[arthur-lemeur]

I think we can close this issue, I just walked through the app to check these points and everything looks good to me.