Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS is currently centralized, should be componentized? #410

Closed
danielweck opened this issue Jul 11, 2019 · 3 comments · Fixed by #1589
Closed

CSS is currently centralized, should be componentized? #410

danielweck opened this issue Jul 11, 2019 · 3 comments · Fixed by #1589
Labels
Projects

Comments

@danielweck
Copy link
Member

https://github.com/readium/readium-desktop/tree/develop/src/renderer/assets/styles

=> all in one folder, but should be tied to specific JSX component?

@danielweck
Copy link
Member Author

Related: #409

@danielweck
Copy link
Member Author

A concrete problematic situation related to this issue:
#681 (comment)

@danielweck
Copy link
Member Author

Also note that some SVG icons contain non-parameterized inline CSS definitions:
https://github.com/readium/readium-desktop/tree/develop/src/renderer/assets/icons

For example:

<style type="text/css">
	.st0{fill:#C1C1C1;}
</style>

This could cause problems when implementing support for OS high-contrast / dark mode.
See #577

The solution we will likely implement is CSS "variables" (custom properties), just like ReadiumCSS, at which point the SVG icons might need tweaking too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
1.8
Done
3 participants