Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Named range tuple #385

Merged
merged 1 commit into from Apr 26, 2022
Merged

feat: Named range tuple #385

merged 1 commit into from Apr 26, 2022

Conversation

golergka
Copy link
Contributor

Makes it easier to understand the meaning behind the type without having to open documentation.

eemeli
eemeli approved these changes Apr 26, 2022
View reviewed changes
Copy link
Owner

@eemeli eemeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I hadn't known that this was a thing.

@eemeli eemeli merged commit 3ed008a into eemeli:master Apr 26, 2022
@xXPOLYGONXx xXPOLYGONXx mentioned this pull request May 18, 2022
Closed
eemeli added a commit that referenced this pull request May 29, 2022
@eemeli
Revert "feat: Use TS named tuple for range (#385)"
98a1d5e 
This reverts commit 3ed008a.
@eemeli
Copy link
Owner

eemeli commented May 30, 2022

Ping @golergka: I needed to revert this in yaml@2.1.1. See #393 for more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eemeli eemeli eemeli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@golergka @eemeli