Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flowCollectionPadding toString option #420

Merged
merged 1 commit into from Nov 1, 2022

Conversation

cemerick
Copy link
Contributor

Hopefully this is a reasonable coverage on docs, tests, and mirrors how other calculated spacings work (e.g. indents). Happy to revise based on feedback. 馃憢

Copy link
Owner

@eemeli eemeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Realistically, the single-line padding will always be either 0 or 1 spaces, so we should make it a boolean rather than a number.

@eemeli eemeli changed the title add flowCollectionPadding toString option, fixes #419 Add flowCollectionPadding toString option Oct 27, 2022
Copy link
Owner

@eemeli eemeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! The API docs could do with a slight tweak, though.

docs/03_options.md Outdated Show resolved Hide resolved
src/options.ts Outdated Show resolved Hide resolved
@eemeli eemeli merged commit 29732f3 into eemeli:master Nov 1, 2022
@cemerick cemerick deleted the flow-collection-padding branch November 1, 2022 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for configuring padding surrounding items in flow collections
2 participants