Skip to content
This repository has been archived by the owner on Feb 20, 2019. It is now read-only.

Add a findDuplicates function #53

Open
diwesh87 opened this issue Nov 17, 2016 · 14 comments
Open

Add a findDuplicates function #53

diwesh87 opened this issue Nov 17, 2016 · 14 comments

Comments

@diwesh87
Copy link

Hi got here watching your course "How to Contribute to an Open Source project on GitHub. I would like to add a "findDuplicates" function. The original solution can be found here at Find duplicate values in a JavaScript array

@kentcdodds
Copy link
Member

Awesome! I recommend my favorite answer, but feel free to use whichever you like. I'm looking forward to seeing your implementation!

@engeman2008
Copy link

I want to contribute to this issue. This is my first time to contribute in githup repository.

@kentcdodds
Copy link
Member

@engeman2008, thank you for your interested. Do you think you could actually create your own issue with a different Stack Overflow answer? I would prefer to leave this one for @diwesh87 who had the idea in the first place :)

Thanks!

@engeman2008
Copy link

Okay. i didnt get the idea at first. i thought i could contribute to any issue.
Thanks.

@kentcdodds
Copy link
Member

Thanks @engeman2008, I should probably open up a few issues for people to select... Thanks for understanding :)

@engeman2008
Copy link

Yes, this would be great.
Thanks.

@kentcdodds
Copy link
Member

I added some.

@mtheoryx
Copy link
Contributor

mtheoryx commented Dec 1, 2016

@kentcdodds Are you opposed to people opening issues as ideas? Or should they take only open ones? Or can they only open issues they intend to solve?

Just trying to get a sense of what you're expecting regarding issues for clarity.

Cheers!

@kentcdodds
Copy link
Member

I would prefer people to open their own. But if someone needs some direction, having some existing issues is helpful. Feel free to add some if you have ideas @mtheoryx :)

@goanpixie
Copy link
Contributor

goanpixie commented Apr 13, 2017

Hi @kentcdodds..I am following your course on 'How to contribute to open source projects' and would love to contribute to issues. Could you open some new issues you want to fix/add? It would make the start easier.Thanks!

@kentcdodds
Copy link
Member

@goanpixie, glad that you're going through the series. I think it actually would be a more full experience if you file the issue to start with 😄

@goanpixie
Copy link
Contributor

goanpixie commented Apr 14, 2017

Sounds good!:) I just filed an issue.

@ruimprego
Copy link

As a newbie, how do I find an issue to work in?
This is kind of overwhelming as a beginner.

@kentcdodds
Copy link
Member

Hi @captainSpades,
The best way to contribute to this repo is to come up with your own stack overflow answer you'd like to add to the project and file an issue. You can see what others have done if you need some inspiration for what kinds of things that work here. And be sure to watch this

Good luck!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants