Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📦 NEW: [BREAKING] Only support Node.js 14 #176

Merged
merged 11 commits into from Jun 4, 2022
Merged

📦 NEW: [BREAKING] Only support Node.js 14 #176

merged 11 commits into from Jun 4, 2022

Conversation

fengmk2
Copy link
Member

@fengmk2 fengmk2 commented Jun 3, 2022

remove nyc

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@fengmk2 fengmk2 requested a review from atian25 June 3, 2022 16:52
@fengmk2 fengmk2 self-assigned this Jun 3, 2022
@fengmk2 fengmk2 changed the title 📦 NEW: [BREAKNING] Only support Node.js 14 📦 NEW: [BREAKING] Only support Node.js 14 Jun 3, 2022
@codecov
Copy link

codecov bot commented Jun 3, 2022

Codecov Report

Merging #176 (b84eaba) into master (1e96da2) will decrease coverage by 1.41%.
The diff coverage is 97.29%.

❗ Current head b84eaba differs from pull request most recent head 121f470. Consider uploading reports for the commit 121f470 to get more accurate results

@@             Coverage Diff             @@
##            master     #176      +/-   ##
===========================================
- Coverage   100.00%   98.58%   -1.42%     
===========================================
  Files           13       28      +15     
  Lines          266      992     +726     
  Branches         4       29      +25     
===========================================
+ Hits           266      978     +712     
- Misses           0       14      +14     
Impacted Files Coverage Δ
lib/mocha-clean.js 100.00% <ø> (ø)
lib/cmd/autod.js 53.57% <50.00%> (-46.43%) ⬇️
lib/cmd/cov.js 100.00% <100.00%> (ø)
lib/cmd/debug.js 100.00% <100.00%> (ø)
lib/cmd/dev.js 100.00% <100.00%> (ø)
lib/cmd/pkgfiles.js 100.00% <100.00%> (ø)
lib/cmd/test.js 100.00% <100.00%> (ø)
test/fixtures/example-ts-pkg/app/router.ts 100.00% <100.00%> (ø)
index.js 100.00% <0.00%> (ø)
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f32030b...121f470. Read the comment docs.

@fengmk2 fengmk2 merged commit 6fb02f9 into master Jun 4, 2022
@fengmk2 fengmk2 deleted the node-14 branch June 4, 2022 02:27
@fengmk2
Copy link
Member Author

fengmk2 commented Jun 4, 2022

5.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant