Skip to content

Commit 24cb888

Browse files
committedFeb 22, 2019
fix: use defaultFileName as the second arg of output.fileName
1 parent 7e58839 commit 24cb888

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed
 

‎src/index.ts

+4-3
Original file line numberDiff line numberDiff line change
@@ -387,10 +387,11 @@ export class Bundler {
387387
}
388388
})
389389

390-
const getFileName = config.output.fileName || defaultGetFileName
390+
const defaultFileName = getDefaultFileName(rollupFormat)
391+
const getFileName = config.output.fileName || defaultFileName
391392
const fileNameTemplate =
392393
typeof getFileName === 'function'
393-
? getFileName({ format: rollupFormat, minify })
394+
? getFileName({ format: rollupFormat, minify }, defaultFileName)
394395
: getFileName
395396
const fileName = fileNameTemplate
396397
.replace(/\[min\]/, minPlaceholder)
@@ -654,7 +655,7 @@ async function printAssets(assets: Assets, title: string) {
654655
)
655656
}
656657

657-
function defaultGetFileName({ format }: FileNameContext) {
658+
function getDefaultFileName(format: RollupFormat) {
658659
const isESM = /^esm?$/.test(format)
659660
return format === 'cjs' || isESM
660661
? `[name][min][ext]`

‎src/types.ts

+4-1
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,10 @@ export interface FileNameContext {
4040
minify: boolean
4141
}
4242

43-
export type GetFileName = (context: FileNameContext) => string
43+
export type GetFileName = (
44+
context: FileNameContext,
45+
defaultFileName: string
46+
) => string
4447

4548
export interface BabelPresetOptions {
4649
/**

0 commit comments

Comments
 (0)
Please sign in to comment.