Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsupported source map comment #11

Closed
AlCalzone opened this issue Feb 22, 2021 · 4 comments · Fixed by #27
Closed

Unsupported source map comment #11

AlCalzone opened this issue Feb 22, 2021 · 4 comments · Fixed by #27
Labels

Comments

@AlCalzone
Copy link

I'm getting a ton of these when running scripts with esbuild-register:

{
  column: 21,
  file: 'C:\\Repositories\\node-zwave-js\\packages\\core\\build\\index.js',
  length: 12,
  line: 32,
  lineText: '//# sourceMappingURL=index.js.map',
  namespace: ''
}
Unsupported source map comment
{
  column: 21,
  file: 'C:\\Repositories\\node-zwave-js\\packages\\core\\build\\capabilities\\CommandClasses.js',
  length: 21,
  line: 245,
  lineText: '//# sourceMappingURL=CommandClasses.js.map',
  namespace: ''
}
Unsupported source map comment
{
  column: 21,
  file: 'C:\\Repositories\\node-zwave-js\\packages\\shared\\build\\index.js',
  length: 12,
  line: 21,
  lineText: '//# sourceMappingURL=index.js.map',
  namespace: ''
}

Any idea what I can do?

@natew
Copy link
Contributor

natew commented Mar 1, 2021

Getting this too, if you change sourcemap: 'both' to false in dist/node.js you can patch for now to disable sourcemaps but not get the errors.

@jinjor
Copy link

jinjor commented Apr 13, 2021

This message seems to come from this line in esbuild:
https://github.com/evanw/esbuild/blob/c5a88a04561debf302243b0afd11d365257a2373/internal/bundler/bundler.go#L551

In my case, rebuilding the local package with "inlineSourceMap": true (in tsconfig.json) solved the problem.

@AlCalzone
Copy link
Author

See evanw/esbuild#1358 (comment) - esbuild-register uses the transformSync API which does not do path resolution. If it used the buildSync API instead it could support the external source maps.

hardfist added a commit to hardfist/esbuild-register that referenced this issue Jun 12, 2021
egoist added a commit that referenced this issue Jun 12, 2021
* feat: upgrade esbuild to 0.12.8
close #11

* update lockfile

Co-authored-by: yj <yangjian.fe@bytedance.com>
Co-authored-by: EGOIST <0x142857@gmail.com>
@egoist
Copy link
Owner

egoist commented Jun 12, 2021

🎉 This issue has been resolved in version 2.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants