Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ts-essentials is listed as a devDependency #327

Closed
freben opened this issue Jan 20, 2022 · 2 comments
Closed

ts-essentials is listed as a devDependency #327

freben opened this issue Jan 20, 2022 · 2 comments
Labels

Comments

@freben
Copy link

freben commented Jan 20, 2022

However, dist/index.d.ts does import { MarkOptional } from 'ts-essentials';, which leads to

node_modules/rollup-plugin-esbuild/dist/index.d.ts:3:30 - error TS2307: Cannot find module 'ts-essentials' or its corresponding type declarations.

3 import { MarkOptional } from 'ts-essentials';
                               ~~~~~~~~~~~~~~~

because

declare type Options = {
    /* ... */
    optimizeDeps?: MarkOptional<OptimizeDepsOptions, 'cwd' | 'sourceMap'>;
@github-actions
Copy link

github-actions bot commented Apr 6, 2022

🎉 This issue has been resolved in version 4.9.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@egoist
Copy link
Owner

egoist commented Apr 6, 2022

Since this is a type dependency I prefer bundling it using tsup over adding it as a dependency , fixed in 4.9.1, anyways thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants