fix: Exit Code returns 0 for failed builds, closes #606

egoist · Apr 12, 2022 · b3ad95f · b3ad95f · vercel · Apr 12, 2022
1 parent b7cf552
commit b3ad95f
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 10 deletions.
diff --git a/package.json b/package.json
@@ -63,7 +63,7 @@
     "svelte": "3.46.4",
     "ts-essentials": "9.1.2",
     "tsconfig-paths": "3.12.0",
-    "tsup": "5.12.2",
+    "tsup": "5.12.4",
     "typescript": "4.6.3",
     "vitest": "0.8.4",
     "wait-for-expect": "3.0.2"

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/src/index.ts b/src/index.ts
@@ -161,10 +161,8 @@ export async function build(_options: Options) {
               })
               worker.on('message', (data) => {
                 if (data === 'error') {
-                  process.exitCode = 1
-                  reject(new Error('Failed to bundle declaration files'))
+                  reject(new Error('error occured in dts build'))
                 } else if (data === 'success') {
-                  process.exitCode = 0
                   resolve()
                 }
               })

diff --git a/src/rollup.ts b/src/rollup.ts
@@ -243,8 +243,12 @@ const startRollup = async (options: NormalizedOptions) => {
   if (options.watch) {
     watchRollup(config)
   } else {
-    await runRollup(config)
-    parentPort?.postMessage('success')
+    try {
+      await runRollup(config)
+      parentPort?.postMessage('success')
+    } catch (error) {
+      parentPort?.postMessage('error')
+    }
     parentPort?.close()
   }
 }