From b3ad95f9d83d44eb298257489ec8f8698d130f19 Mon Sep 17 00:00:00 2001 From: EGOIST Date: Tue, 12 Apr 2022 20:44:23 +0800 Subject: [PATCH] fix: Exit Code returns 0 for failed builds, closes #606 --- package.json | 2 +- pnpm-lock.yaml | 8 ++++---- src/index.ts | 4 +--- src/rollup.ts | 8 ++++++-- 4 files changed, 12 insertions(+), 10 deletions(-) diff --git a/package.json b/package.json index d5b05912..04bcda60 100644 --- a/package.json +++ b/package.json @@ -63,7 +63,7 @@ "svelte": "3.46.4", "ts-essentials": "9.1.2", "tsconfig-paths": "3.12.0", - "tsup": "5.12.2", + "tsup": "5.12.4", "typescript": "4.6.3", "vitest": "0.8.4", "wait-for-expect": "3.0.2" diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index ee47b83a..77794ecb 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -37,7 +37,7 @@ specifiers: tree-kill: ^1.2.2 ts-essentials: 9.1.2 tsconfig-paths: 3.12.0 - tsup: 5.12.2 + tsup: 5.12.4 typescript: 4.6.3 vitest: 0.8.4 wait-for-expect: 3.0.2 @@ -81,7 +81,7 @@ devDependencies: svelte: 3.46.4 ts-essentials: 9.1.2_typescript@4.6.3 tsconfig-paths: 3.12.0 - tsup: 5.12.2_typescript@4.6.3 + tsup: 5.12.4_typescript@4.6.3 typescript: 4.6.3 vitest: 0.8.4 wait-for-expect: 3.0.2 @@ -1522,8 +1522,8 @@ packages: strip-bom: 3.0.0 dev: true - /tsup/5.12.2_typescript@4.6.3: - resolution: {integrity: sha512-CZcM4UGYlKcdQzDIJbrwgpn4sQe8zobnHRgAF6C8RpMGvfRov9ipSQY3mjjnZRAkEZQO1+Jr3cxeaQJjY/iVTg==} + /tsup/5.12.4_typescript@4.6.3: + resolution: {integrity: sha512-uUraITfIj2h6rXAdeaVUYrZ2Is9joLFyEGZN5mGAke874JojCizb2MCUcE0wGdcERtyob5mbbFUKkMgal8SlFw==} hasBin: true peerDependencies: typescript: ^4.1.0 diff --git a/src/index.ts b/src/index.ts index 3732bb5e..441a91d1 100644 --- a/src/index.ts +++ b/src/index.ts @@ -161,10 +161,8 @@ export async function build(_options: Options) { }) worker.on('message', (data) => { if (data === 'error') { - process.exitCode = 1 - reject(new Error('Failed to bundle declaration files')) + reject(new Error('error occured in dts build')) } else if (data === 'success') { - process.exitCode = 0 resolve() } }) diff --git a/src/rollup.ts b/src/rollup.ts index f7128da0..ad48b91a 100644 --- a/src/rollup.ts +++ b/src/rollup.ts @@ -243,8 +243,12 @@ const startRollup = async (options: NormalizedOptions) => { if (options.watch) { watchRollup(config) } else { - await runRollup(config) - parentPort?.postMessage('success') + try { + await runRollup(config) + parentPort?.postMessage('success') + } catch (error) { + parentPort?.postMessage('error') + } parentPort?.close() } }