Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optionalDependencies should be excluded by default #1099

Open
IlyaSemenov opened this issue Mar 26, 2024 · 0 comments
Open

optionalDependencies should be excluded by default #1099

IlyaSemenov opened this issue Mar 26, 2024 · 0 comments

Comments

@IlyaSemenov
Copy link

IlyaSemenov commented Mar 26, 2024

By default tsup bundles all imported modules but dependencies and peerDependencies in package.json are always excluded.

I believe that optionalDependencies should be also excluded by default, as they are essentially the dependencies which are simply allowed to not exist, and the library author is supposed to import them dynamically and handle failed imports gracefully.

Upvote & Fund

  • We're using Polar.sh so you can upvote and help fund this issue.
  • We receive the funding once the issue is completed & confirmed by you.
  • Thank you in advance for helping prioritize & fund our backlog.
Fund with Polar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant