support loading config from a parent folder (monorepo)

[jcayzac]

Hi @egoist!

My project structure has:

+-- project
    +-- packages
    |   +-- library
    +-- tsup.config.ts

When I call tsup from the library folder, it fails to find the config file. I see you're setting joycon's stopDir to the current project's folder:

tsup/src/load.ts

Lines 44 to 55 in 405e165

	const configPath = await configJoycon.resolve(
	[
	'tsup.config.ts',
	'tsup.config.js',
	'tsup.config.cjs',
	'tsup.config.mjs',
	'tsup.config.json',
	'package.json',
	],
	cwd,
	path.dirname(cwd)
	)

Would you have any objection to changing that and allow resolve() to traverse the filesystem upward?

export async function loadTsupConfig(cwd: string) {
  const configJoycon = new JoyCon()
  const configPath = await configJoycon.resolve(
    [
      'tsup.config.ts',
      'tsup.config.js',
      'tsup.config.cjs',
      'tsup.config.mjs',
      'tsup.config.json',
      'package.json',
    ],
-   cwd,
-   path.dirname(cwd)
+   cwd
  )

Thanks!

[jcayzac]

Basically this would spare me having to write dummy one-line tsup.config.ts files in each of my packages, with just export * from '../../tsup.config'.

[github-actions]

🎉 This issue has been resolved in version 5.10.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[michael-land]

does this still work in 5.12.1?

No input files, try "tsup <your-file>" instead

+-- project
    +-- packages
    |   +-- library
    +-- tsup.config.ts

[schelmo]

no it isnt for me too.
i think the code in

tsup/src/load.ts

Lines 39 to 50 in b8c51f4

	const configPath = await configJoycon.resolve(
	[
	'tsup.config.ts',
	'tsup.config.js',
	'tsup.config.cjs',
	'tsup.config.mjs',
	'tsup.config.json',
	'package.json',
	],
	cwd,
	path.parse(cwd).root
	)

should first check for tsup.config.{ts,js,cjs,mjs,ts,json}
and after that, check for package.json
so if there is a tsup.config.ts in workspace root, take that, else check for package.json

[github-actions]

🎉 This issue has been resolved in version 5.12.7 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀