feat(minor): support node:
import in older node versions
#460
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Bundling a dependency with
import fs from 'node:fs'
didn't work with Node v12 because it would convert the import statement to arequire
, which requires Node v14.18.0.Changes
node:
protocoldisabled
option inexternalPlugin
in favor of not passing it into esbuild in the first place. Minor performance nitpick since I didn't want to have two different ways of disabling plugins.