Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only use esm shim for node platform #475

Merged
merged 1 commit into from Nov 30, 2021
Merged

fix: only use esm shim for node platform #475

merged 1 commit into from Nov 30, 2021

Conversation

zhmushan
Copy link
Contributor

@vercel
Copy link

vercel bot commented Nov 30, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/egoist/tsup/F6f8jQ5C6R1TVCpon2bRYDwZ9cWn
✅ Preview: https://tsup-git-fork-zhmushan-dev-egoist.vercel.app

@egoist egoist changed the title fix: esm shim not working on browser fix: only use esm shim for node platform Nov 30, 2021
@egoist egoist merged commit 29dcb8e into egoist:dev Nov 30, 2021
@egoist
Copy link
Owner

egoist commented Nov 30, 2021

they will only be injected when you actually use __dirname and __filename, and you normally won't do that when building browser-oriented libraries.

@zhmushan zhmushan deleted the dev branch November 30, 2021 10:15
@github-actions
Copy link

github-actions bot commented Dec 2, 2021

🎉 This PR is included in version 5.10.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@zhmushan zhmushan mentioned this pull request Dec 14, 2021
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants