feat: Simple CSS injection support #483
Merged
+100
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/egoist/tsup/6dKptyojEZxQuWeCPziNMci6H9yu |
|
@egoist I will not implement configuration inheritance here (let the transformer know if the user has configured sourcemap, minify, etc.), nor will I split the module and abstract it. I'm afraid that if I do this, it will cause confusion for the author. This is just a quick implementation, hopefully the author can reorganize this part of the code in a more logical way, and rename the API if necessary. |
|
@egoist Any other suggestions? |
egoist
added a commit
that referenced
this pull request
Dec 10, 2021
Co-authored-by: EGOIST <0x142857@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very preliminary CSS injection support, which cannot be flexibly configured
close: #479