fix: Fix broken sourcemap comment generation for .css files
#492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the moment `.css` files generated when the `sourcemap` flag is `true` have a sourcemap comment at the bottom of the file that makes the file invalid: `//# sourceMappingURL=index.css.map` As indicated in the MDN [docs](https://developer.mozilla.org/en-US/docs/Tools/Debugger/How_to/Use_a_source_map) and the [specification](https://sourcemaps.info/spec.html#h.lmz475t4mvbx) for source map, the comment pointing to the source map for CSS files needs to use the `/*# sourceMappingURL=/path/to/sourcemap.map */` syntax. This PR should create a valid sourcemap comment for both `.css` and `.js` files. Feel free to adjust the code to fit whatever style makes the most sense for your library.
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/egoist/tsup/Cf1xbvaiUcJojsTTievczX73Gdqp |
egoist
changed the title
.css files.css files
|
🎉 This PR is included in version 5.11.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
xesrevinu
reviewed
Dec 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment
.cssfiles generated when thesourcemapflag istruehave a sourcemap comment at the bottom of the file that makes the file invalid://# sourceMappingURL=index.css.mapAs indicated in the MDN docs and the specification for source map, the comment pointing to the source map for CSS files needs to use the
/*# sourceMappingURL=/path/to/sourcemap.map */syntax.This PR should create a valid sourcemap comment for both
.cssand.jsfiles. Feel free to adjust the code to fit whatever style makes the most sense for your library.And of course, thank you for the fantastic library. Exceptionally useful.