New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option sourcemap: 'inline'
not working
#495
Comments
inline sourcemap was removed and the docs should be updated, any specific reason you need inline sourcemap? |
I am developing a custom tsup configuration that takes some paramters that tsup care about directly from the tsconfig.json.
Should we remove the |
just did a bit research, there're indeed use cases for inline sourcemap (like developing browser extensions), we should bring it back, but it should be added in Lines 160 to 174 in d428ce7
|
🎉 This issue has been resolved in version 5.11.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Hi!
As per documentation it should be possible to pass
inline
assourcemap
option. In reality, passing it is treated the same as passing any other value thanks to this line: https://github.com/egoist/tsup/blob/dev/src/esbuild/index.ts#L134Moreover, the relative test is wrong too and doesn't catch this error. We can see that it is checking for the presence of
at https://github.com/egoist/tsup/blob/dev/test/index.test.ts#L188 instead of the more safe
//# sourceMappingURL=data:
I've already had a fix, and I can open a PR, but there is just one last thing that bothers me.
esbuild
documentation says thatexternal
shouldn't add//# sourceMappingURL=
at the end of the file, but running this test and checking the output, shows a different story. Any clues?And this is why the
inline
test is passing even if the option is not working at the moment.Upvote & Fund
The text was updated successfully, but these errors were encountered: