Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--target es5 and --minify dont' work together #653

Closed
nkappler opened this issue Jun 9, 2022 · 4 comments
Closed

--target es5 and --minify dont' work together #653

nkappler opened this issue Jun 9, 2022 · 4 comments
Labels

Comments

@nkappler
Copy link

nkappler commented Jun 9, 2022

Title says it all, when I add --target es5 to my command, the output isn't minified anymore

@nkappler
Copy link
Author

nkappler commented Jun 9, 2022

also, I have specified

    "compilerOptions": {
        "target": "ES5",

in my tsconfig.json, which basically is ignored... I would expect this to work :/

@egoist egoist closed this as completed in 8230221 Jun 10, 2022
@egoist
Copy link
Owner

egoist commented Jun 10, 2022

    "compilerOptions": {
        "target": "ES5",

in my tsconfig.json, which basically is ignored... I would expect this to work :/

Yeah! But esbuild only supports a subset of tsconfig target, I may add support for this if I figure out how to do it properly.

@github-actions
Copy link

🎉 This issue has been resolved in version 6.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@nkappler
Copy link
Author

that was fast, thanks a lot 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants