Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add option to override tsconfig #660

Merged
merged 3 commits into from Jul 25, 2022
Merged

feat: add option to override tsconfig #660

merged 3 commits into from Jul 25, 2022

Conversation

sxzz
Copy link
Collaborator

@sxzz sxzz commented Jun 19, 2022

I'm a little confused. Since we have loadTsConfig, why we still load the config from loadCompilerOptions? I think we can parse it directly.

@vercel
Copy link

vercel bot commented Jun 19, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
tsup ✅ Ready (Inspect) Visit Preview Jul 25, 2022 at 2:43PM (UTC)

@egoist
Copy link
Owner

egoist commented Jul 25, 2022

the idea is to reuse options in tsconfig.json as much as possible, just like how esbuild respects options in tsconfig.json

@egoist
Copy link
Owner

egoist commented Jul 25, 2022

sorry I misunderstood this pr, your are right 🫡

@github-actions
Copy link

🎉 This PR is included in version 6.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants