fix: fix typo in postcssPlugin #764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building with tsup I have configured esbuild to use the new [`copy` loader](https://esbuild.github.io/content-types/#copy) for CSS files: ``` const { build } = require('tsup'); build({ // ... loader: { '.css': 'copy' }, }); ``` Unfortunately this is causing an error when building due to an old version of `postcss` I have in my dependency tree: ``` ✘ [ERROR] [plugin postcss] postcss.default is not a function ../../utilities/module-scripts/node_modules/tsup/dist/index.js:1348:74: 1348 │ const result = await (postcss == null ? void 0 : postcss.default(plugins).process(contents, { ...options, from: args.path })); ``` I was trying to figure out why tsup was trying to invoke postcss at all, and discovered what looks like a typo, which causes invocation of postcss even if there is no postcss config present. One thing I am not sure about: I feel like given my config we should not be including the esbuild `postcssPlugin` at all? So maybe this should also be fixed at a higher level? But this was sufficient to avoid the error.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
I was thinking about e.g. a way to configure tsup and tell it not to do anything CSS-related at all. I guess with |
|
🎉 This PR is included in version 6.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
amitdahan
pushed a commit
to amitdahan/tsup
that referenced
this pull request
Dec 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building with tsup I have configured esbuild to use the new
copyloader for CSS files:Unfortunately this is causing an error when building due to an old version of
postcssI have in my dependency tree:I was trying to figure out why tsup was trying to invoke postcss at all, and discovered what looks like a typo, which causes invocation of postcss even if there is no postcss config present.
One thing I am not sure about: I feel like given my config we should not be including the esbuild
postcssPluginat all? So maybe this should also be fixed at a higher level? But this was sufficient to avoid the error.