Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for sourcemap: external, both #775

Open
segevfiner opened this issue Nov 16, 2022 · 2 comments · May be fixed by #781
Open

Add support for sourcemap: external, both #775

segevfiner opened this issue Nov 16, 2022 · 2 comments · May be fixed by #781

Comments

@segevfiner
Copy link
Contributor

segevfiner commented Nov 16, 2022 •
edited by polar-sh bot

I think sourcemap: true, currently maps to linked, but there are also other modes supported by esbuild that are useful, such as external which generates a sourcemap without a sourceMappingUrl or both which is both inline and external.

Upvote & Fund

  • We're using Polar.sh so you can upvote and help fund this issue.
  • We receive the funding once the issue is completed & confirmed by you.
  • Thank you in advance for helping prioritize & fund our backlog.
Fund with Polar
justusburger added a commit to justusburger/tsup that referenced this issue Nov 19, 2022
@justusburger
Expose all esbuild's sourcemap options
6523883 
Resolves egoist#775
@justusburger justusburger linked a pull request Nov 19, 2022 that will close this issue
Open
@justusburger
Copy link

Interestingly, from my testing it seems like the options external and linked both produce the same result, i.e. a .js.map file with a //# sourceMappingURL=input.js.map appended to the end of the .js.

@segevfiner
Copy link
Contributor Author

Interestingly, from my testing it seems like the options external and linked both produce the same result, i.e. a .js.map file with a //# sourceMappingURL=input.js.map appended to the end of the .js.

With plain esbuild?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Expose all esbuild's sourcemap options justusburger/tsup
2 participants
@justusburger @segevfiner