Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: raise node engine requirement to 14.18 #832

Merged
merged 1 commit into from Feb 14, 2023
Merged

fix: raise node engine requirement to 14.18 #832

merged 1 commit into from Feb 14, 2023

Conversation

rayzr522
Copy link
Contributor

closes #825

rollup themselves have this as the engine requirement: https://github.com/rollup/rollup/blob/f125345413ea686003fb4f4c650a79c321372d45/package.json#L156

this is necessary bc 14.18.0 is when support for node:-prefixed imports was added, which are now apparently included in the rollup bundle 😅
image
(source)

@vercel
Copy link

vercel bot commented Feb 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
tsup ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 11, 2023 at 6:24AM (UTC)

@socket-security
Copy link

Socket Security Pull Request Report

Dependency issues detected. If you merge this pull request, you will not be alerted to the instances of these issues again.

📜 Install scripts

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Package Script field Source
@swc/core@1.3.35 (upgraded) postinstall package.json via tsup@6.4.0
esbuild@0.17.7 (upgraded) postinstall package.json via bundle-require@4.0.1
Pull request report summary
Issue Status
Install scripts ⚠️ 2 issues
Native code ✅ 0 issues
Bin script confusion ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues
Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@2.4.2

  • @SocketSecurity ignore @swc/core@1.3.35
  • @SocketSecurity ignore esbuild@0.17.7

⚠️ Please accept the latest app permissions to ensure bot commands work properly. Accept the new permissions here.

Powered by socket.dev

@rayzr522 rayzr522 changed the title fix: raise node engine reuqirement to 14.18 fix: raise node engine requirement to 14.18 Feb 11, 2023
@github-actions
Copy link

🎉 This PR is included in version 6.6.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@rayzr522 rayzr522 deleted the raise-node-engine-requirement-to-14.18 branch February 14, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: Cannot find module 'node:path'
2 participants