Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPR & Github JIRA Integration does not "play nice" #318

Open
jameskyle opened this issue May 6, 2023 · 0 comments
Open

SPR & Github JIRA Integration does not "play nice" #318

jameskyle opened this issue May 6, 2023 · 0 comments

Comments

@jameskyle
Copy link

Problem

I've used a couple of different JIRA / Github integrations and they seem to essentially work the same way.

  1. If a PR references an issue ID in the commit msg head or body that issue is associated to the PR
  2. If the PR is merged, the jira issue is transitioned through the JIRA workflow (e.g. moved to in progress once submitted)
  3. Issue is resolved once merged.

SPR builds a PR chain with one link for each commit. Each commit message may reference a different Jira Issue and each Jira issue is moved to "in progress" when the stack is first updated (PR's created).

If you run a git spr merge with multiple commits ready to merge, SPR "rolls up" the stack and closes the previous PR.

The process of "rolling up" does not trigger a new association by the JIRA Integrations I've used.

The end result when the final PR is merged is the original Jira Issue associated with that PR is closed. But the others in the stack remain open.

Work Around

The work around I've found is to do a git spr merge --count 1. Wait for it to merge, update, then merge the next. This works, but is tedious.

Possible solutions

One solution that may work is to actually commit the merge for the PR instead of closing and rolling up locally. This should trigger the Issue transition to Done/Resolved. Then just clean up the branch and let the final PR merge as it does now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant