Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message on empty .spr.yml #334

Open
ggoretkin-bdai opened this issue Jun 12, 2023 · 1 comment
Open

Error message on empty .spr.yml #334

ggoretkin-bdai opened this issue Jun 12, 2023 · 1 comment

Comments

@ggoretkin-bdai
Copy link

It would be good to mention the filename .spr.yml in the following message:

$ git-spr --help
panic: EOF

goroutine 1 [running]:
github.com/ejoffe/rake.check(...)
	/Users/runner/go/pkg/mod/github.com/ejoffe/rake@v0.2.7/config.go:27
github.com/ejoffe/rake.(*yamlSource).Load(0xc0001f8f70, {0x7f9400, 0xc000147cc0})
	/Users/runner/go/pkg/mod/github.com/ejoffe/rake@v0.2.7/yaml_source.go:31 +0x2c5
github.com/ejoffe/rake.LoadSources({0x7f9400, 0xc000147cc0}, {0xc0001c3dd8, 0x4, 0x8c})
	/Users/runner/go/pkg/mod/github.com/ejoffe/rake@v0.2.7/config.go:21 +0xa9
github.com/ejoffe/spr/config/config_parser.ParseConfig({0x92d978, 0xc000130a50})
	/Users/runner/work/spr/spr/config/config_parser/config_parser.go:17 +0x30d
main.main()
	/Users/runner/work/spr/spr/cmd/spr/main.go:42 +0x156
@piefel
Copy link

piefel commented Dec 11, 2023

It would be good not to panic. spr also panics on a YAML file containing only comments. Combined with #372 it makes the getting started process a bit hairy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants