Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add --no-verify to git amend #366

Open
b-chu opened this issue Nov 9, 2023 · 6 comments
Open

add --no-verify to git amend #366

b-chu opened this issue Nov 9, 2023 · 6 comments
Labels
enhancement New feature or request

Comments

@b-chu
Copy link
Contributor

b-chu commented Nov 9, 2023

There should be a way to skip pre-commit hooks

@ejoffe
Copy link
Owner

ejoffe commented Nov 9, 2023

Can you add more details please.
In what cases would you want to skip commit hooks?

@b-chu
Copy link
Contributor Author

b-chu commented Nov 9, 2023

When using git amend

@ejoffe
Copy link
Owner

ejoffe commented Nov 9, 2023

Are these custom pre-commit hooks that you have? or the commit msg hook that spr runs while updating the stack?

@b-chu
Copy link
Contributor Author

b-chu commented Nov 9, 2023

git commit allows for --no-verify and spr uses git commit but doesn't allow for --no-verify
https://git-scm.com/docs/git-commit

@ejoffe
Copy link
Owner

ejoffe commented Nov 9, 2023

git amend uses git commit --fixup + git rebase
if you want to add --no-verify there it's possible.
the code is in:

cmd/amend/main.go
spr/spr.go : AmendCommit function

Pull requests are welcome.

@piefel
Copy link

piefel commented Dec 13, 2023

Is this the same as or only quite similar to #293 ?

@ejoffe ejoffe added the enhancement New feature or request label Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants