Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support reading github token from system encrypted storage #373

Open
phanhuyn opened this issue Dec 12, 2023 · 0 comments
Open

Support reading github token from system encrypted storage #373

phanhuyn opened this issue Dec 12, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@phanhuyn
Copy link

phanhuyn commented Dec 12, 2023 •
edited

Why

  • Currently, spr retrieves the github token from plaintext config:

    spr/github/githubclient/client.go

    Line 80 in 66dd2f0

    func findToken(githubHost string) string {
  • Since git cli 2.24.0, gh auth login supports --secure-storage by default, and stores the token in system encrypted storage.
  • This causes spr to fail with No GitHub OAuth token found!

What

  • Support retrieving token from system encrypted storage
@phanhuyn phanhuyn changed the title Support reading github token from system encrypted token Support reading github token from system encrypted storage Dec 12, 2023
@ejoffe ejoffe added the enhancement New feature or request label Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ejoffe @phanhuyn