Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete branch after close PR in merged stack #382

Open
levibostian opened this issue Jan 14, 2024 · 1 comment
Open

Delete branch after close PR in merged stack #382

levibostian opened this issue Jan 14, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@levibostian
Copy link
Contributor

Creating issue from discussion

Expected behavior

  • Create a new branch off main.
  • Create commits on new branch.
  • Run git spr update to create stack.
  • Run git spr merge when ready to merge stack.
  • All open PRs get merged/closed by spr. Commits get merged into main. And all spr/ branches on my remote repository that were created by spr to create the PR stack all get deleted.

Actual behavior

  • ...
  • My github repo after running git spr merge will still have spr/ branches that did not get deleted. I need to manually go into github and delete those branches. I have noticed that the branches that do not get deleted are branches that are associated with the PRs that got closed (not the one that got merged by spr).
@levibostian
Copy link
Contributor Author

Opened a PR with an attempt at implementing this feature.

I got stuck on writing tests. Otherwise, I think the feature is as simple as what the PR added?

Any feedback is welcome. Thanks for the consideration of this feature!

@ejoffe ejoffe added the enhancement New feature or request label Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants