.travis.yml

@@ -2,6 +2,7 @@ language: node_js
 node_js:
   - "10.3"
   - "12"
+  - "13"
 install:
   - npm ci
 script:

CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## 6.1.1
+
+- Fix #286 sitemapindex tag not closing for deprecated createSitemapsAndIndex
+
 ## 6.1.0
 
 - Added back xslUrl option removed in 5.0.0

lib/sitemap-index-stream.ts

@@ -139,15 +139,17 @@ export async function createSitemapsAndIndex({
         } else {
           pipe = sms.pipe(ws);
         }
-        chunk.forEach(smi => sms.write(smi));
+        chunk.forEach((smi) => sms.write(smi));
         sms.end();
         pipe.on('finish', () => resolve(true));
-        pipe.on('error', e => reject(e));
+        pipe.on('error', (e) => reject(e));
       });
     }
   );
-  indexWS.end();
-  return Promise.all(smPromises).then(() => true);
+  return Promise.all(smPromises).then(() => {
+    indexStream.end();
+    return true;
+  });
 }
 
 type getSitemapStream = (i: number) => [IndexItem | string, SitemapStream];

lib/sitemap-item-stream.ts

@@ -74,7 +74,7 @@ export class SitemapItemStream extends Transform {
       }
     }
 
-    item.video.forEach(video => {
+    item.video.forEach((video) => {
       this.push(otag(TagNames['video:video']));
 
       this.push(element(TagNames['video:thumbnail_loc'], video.thumbnail_loc));
@@ -205,7 +205,7 @@ export class SitemapItemStream extends Transform {
       this.push(ctag(TagNames['video:video']));
     });
 
-    item.links.forEach(link => {
+    item.links.forEach((link) => {
       this.push(
         element(TagNames['xhtml:link'], {
           rel: 'alternate',

lib/sitemap-stream.ts

@@ -100,7 +100,7 @@ export class SitemapStream extends Transform {
     this.hostname = opts.hostname;
     this.level = opts.level || ErrorLevel.WARN;
     this.smiStream = new SitemapItemStream({ level: opts.level });
-    this.smiStream.on('data', data => this.push(data));
+    this.smiStream.on('data', (data) => this.push(data));
     this.lastmodDateOnly = opts.lastmodDateOnly || false;
     this.xmlNS = opts.xmlns || defaultXMLNS;
     this.xslUrl = opts.xslUrl;

lib/utils.ts

@@ -282,7 +282,7 @@ export class ReadlineStream extends Readable {
     });
 
     // Every time there's data, push it into the internal buffer.
-    this._source.on('line', chunk => {
+    this._source.on('line', (chunk) => {
       // If push() returns false, then stop reading from source.
       if (!this.push(chunk)) this._source.pause();
     });