Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ BUG ] warning: failed to load external entity "./schema/all.xsd" S #254

Closed
damusix opened this issue Oct 23, 2019 · 1 comment
Closed
Labels
confirmed Issue has been confirmed

Comments

@damusix
Copy link

damusix commented Oct 23, 2019

Describe the bug
Either a bug or bad error output for CLI tool

> npx sitemap --validate sitemap.xml 
warning: failed to load external entity "./schema/all.xsd"
Schemas parser error : Failed to locate the main schema resource at './schema/all.xsd'.
WXS schema ./schema/all.xsd failed to compile

Also, docs: https://github.com/ekalinin/sitemap.js#cli
Do not match code: https://github.com/ekalinin/sitemap.js/blob/master/cli.ts#L12

Expected behavior
Better error output or a functional CLI tool. Proper documentation.

Desktop (please complete the following information):
sitemap v5.0.0
node 10
osx mojave 10.14.5

Additional context
Context on docs: I have a feeling there was an undocumented API change because I've seen various things in the docs that don't match up with the code, eg: https://github.com/ekalinin/sitemap.js#example-of-most-of-the-options-you-can-use-for-sitemap (streamToSitemap(smStream).then(console.log))

@damusix damusix changed the title [ BUG ] <Replace with bug title> [ BUG ] warning: failed to load external entity "./schema/all.xsd" S Oct 23, 2019
@derduher
Copy link
Collaborator

good catch on validate vs verify in the docs. I'll look into why its not loading all.xsd
And yeah v5 was released around a week ago so some docs have mistakes. Thanks and feel free to call out anything else that is either wrong or confusing.

@derduher derduher added confirmed Issue has been confirmed and removed needs investigation labels Oct 23, 2019
derduher added a commit that referenced this issue Oct 23, 2019

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
fix #254 documentation, cli errors
@derduher derduher mentioned this issue Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed Issue has been confirmed
Projects
None yet
Development

No branches or pull requests

2 participants