Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I just want to use the date as the lastmod, I don't want to have time. #255

Closed
coldhurt opened this issue Oct 23, 2019 · 7 comments · Fixed by #260
Closed

I just want to use the date as the lastmod, I don't want to have time. #255

coldhurt opened this issue Oct 23, 2019 · 7 comments · Fixed by #260
Labels
accepted Feature is defined and ready to work on

Comments

@coldhurt
Copy link

I just want to use the date as the lastmod, I don't want to have time,
but here is new Date().toISOString(), Is there any way for me to use only the date as lastmod?

@derduher
Copy link
Collaborator

Sorry, no, there is no way to pass the date without it converting to a full ISO date. This is done to simplify the code.
Why do you wish to pass only the date? Perhaps there is a usecase I am missing?

@coldhurt
Copy link
Author

Sorry, no, there is no way to pass the date without it converting to a full ISO date. This is done to simplify the code.
Why do you wish to pass only the date? Perhaps there is a usecase I am missing?

Just product demand, because our search engine baidu is like this :(

@derduher
Copy link
Collaborator

Does baidu not accept or dislike full date + timestamp? I don't know too much about baidu.

@coldhurt
Copy link
Author

Does baidu not accept or dislike full date + timestamp? I don't know too much about baidu.

Its document shows only support date.

@derduher
Copy link
Collaborator

Alright, I will look into supporting this. Any links to documentation would appreciated, especially if they have a validator tool.
Please let me know if there are any other issues you run into using the maps generated with Baidu.

@derduher derduher added accepted Feature is defined and ready to work on and removed needs investigation labels Oct 23, 2019
@coldhurt
Copy link
Author

Alright, I will look into supporting this. Any links to documentation would appreciated, especially if they have a validator tool.
Please let me know if there are any other issues you run into using the maps generated with Baidu.

I found two official wikis, but only Chinese.
https://ziyuan.baidu.com/wiki/640
https://ziyuan.baidu.com/college/courseinfo?id=267&page=2#h2_article_title16
Sorry, i didn't find any validator tool.

@derduher
Copy link
Collaborator

Thank you. This is helpful. It looks like the mobile tag, which I recently dropped as google dropped it, is still required by baidu. I will try to add back support for that as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Feature is defined and ready to work on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants