Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ BUG ] Type definition of dataSource param of simpleSitemapAndIndex is wrong #331

Closed
pinkiebala opened this issue Sep 17, 2020 · 1 comment

Comments

@pinkiebala
Copy link

Describe the bug
Currently, the type of dataSource param of simpleSitemapAndIndex has an option is SitemapItemLoose.

sourceData: SitemapItemLoose | string | Readable | string[];

But the example in Readme can't work

sourceData: [{ url: '/page-1/', changefreq: 'daily'}]

Expected behavior
I believe the type should be SitemapItemLoose[]

Context:

  • Library Version 6.3.0

Additional context
Add any other context about the problem here.

@derduher
Copy link
Collaborator

@pinkiebala Thanks for filing this. A patch has now been released. I wish there was such a thing as "type coverage" so I could add that as a thing to check for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants