Fix parseSitemap and parseSitemapIndex uncatchable errors #375
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parseSitemap
andparseSitemapIndex
both have an issue where errors in the_transform
function are not catchable by the caller and instead result in anUnhandled error
.sitemap.js
but it's not yet clear if the malformed file indicates that there is another bug to be fixed or if that is more indicative of a problem in my consumption of the library. More to follow on that if I find another issue.Before Fix - Output
The output below would result if
parseSitemapIndex
orparseSitemap
were called on a malformed XML file that has an unescaped<
in the text of a tag.