Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace spray-json fork with something for longer term #142

Open
ekrich opened this issue Jan 30, 2021 · 0 comments
Open

Replace spray-json fork with something for longer term #142

ekrich opened this issue Jan 30, 2021 · 0 comments

Comments

@ekrich
Copy link
Owner

ekrich commented Jan 30, 2021

sconfig uses a JSON library to compare the JSON parsing to the internal parser as a sanity check - this could be replaced potentially with a good JSON test lib.

The original lightbend/config uses "net.liftweb" %% "lift-json" % "3.3.0" % Test https://www.liftweb.net/ but this was not cross platform.

This was replaced by https://github.com/jodersky/spray-json to get a cross platform version of
https://github.com/spray/spray-json The code has been merged upstream but it doesn't seem to have a cross version as the master branch is behind and not using current Scala Native versions for example.

It is unclear the path forward but it seems only JVM is involved using TestUtils and JsonTest so right now now cross platform tests are involved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant