Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[idea] structured logs/report #154

Open
so0k opened this issue Apr 25, 2024 · 4 comments
Open

[idea] structured logs/report #154

so0k opened this issue Apr 25, 2024 · 4 comments

Comments

@so0k
Copy link

so0k commented Apr 25, 2024

Rather than rely on string parsing such as this tool oijkn/aws-nuke-exporter, aws-nuke could have an option to output structured logs (--output or --json flag).

@so0k
Copy link
Author

so0k commented Apr 25, 2024

assuming it wouldn't be too hard to add it into here:
https://github.com/ekristen/aws-nuke/blob/main/pkg/commands/global/global.go

let me know if you'd like me to give it a shot and open a PR for this

@ekristen
Copy link
Owner

@so0k this was on my backlog of things I wanted to do. The changes would have to start in libnuke, but wouldn't be super hard. JSON is a given format, but what are you wanting the output to have? Do you have an example?

I'm always down for contributors, but this will require to PRs on two repos to make happen, please check out the contributing docs. I'm following semantic commits, require all commits to be signed. The goal here is to setup some good guidance to allow others to contribute and get things merged quick and reliably instead of them getting stale.

With that in mind, I like this idea, I can probably get it done by the weekend.

@vincenthsh
Copy link

Sounds good @ekristen - I definitely won't have time soon to work on this

@ekristen
Copy link
Owner

ekristen commented Jun 5, 2024

This is a little more difficult to implement. Requires several changes, but I like it and I've been working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants