Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] v0.149.0/0.150.0 prints 0.149.0-dev/0.150.0-dev as version #6835

Closed
EHJ-52n opened this issue Jul 19, 2023 · 4 comments · Fixed by #6841
Closed

[Bug] v0.149.0/0.150.0 prints 0.149.0-dev/0.150.0-dev as version #6835

EHJ-52n opened this issue Jul 19, 2023 · 4 comments · Fixed by #6841
Assignees
Labels

Comments

@EHJ-52n
Copy link
Contributor

EHJ-52n commented Jul 19, 2023

What were you trying to accomplish?

My eksctl update script compares the latest available release version with the version of the currently installed one and installs a new version if the versions are not the same.

What happened?

The current latest available version when asking GitHub API is 0.149.0.
When asking my currently installed eksctl binary which version it is, it reports to be 0.149.0-dev.
As 0.149.0 != 0.149.0-dev the "newer" release is installed everytime my update script is run.

How to reproduce it?

~ curl --silent "https://api.github.com/repos/eksctl-io/eksctl/releases/latest" \
        | jq -r .tag_name \
        | sed 's/v\(.*\)/\1/' ; \
        curl --silent --location "https://github.com/eksctl-io/eksctl/releases/download/v0.149.0/eksctl_$(uname -s)_amd64.tar.gz" \
        | tar xz ; \
        chmod +x ./eksctl ; \
        ./eksctl version ; \
        rm eksctl
0.149.0
0.149.0-dev

Logs

Anything else we need to know?

I am posting this for documentation and hope that the next release will have the postfix -dev removed.

Versions

~ eksctl info                                                
eksctl version: 0.149.0-dev
kubectl version: v1.24.15
OS: linux
@github-actions
Copy link
Contributor

Hello EHJ-52n 👋 Thank you for opening an issue in eksctl project. The team will review the issue and aim to respond within 1-5 business days. Meanwhile, please read about the Contribution and Code of Conduct guidelines here. You can find out more information about eksctl on our website

@jouve
Copy link

jouve commented Jul 20, 2023

up, it happened again with v0.150.0-dev

@a-hilaly
Copy link
Member

I'm expecting this to be coming from https://github.com/eksctl-io/eksctl/blob/main/.goreleaser.yml#L17 - maybe we are missing some env configuration in L13? /cc @cPu1

@EHJ-52n EHJ-52n changed the title [Bug] v0.149.0 prints 0.149.0-dev as version [Bug] v0.149.0/0.150.0 prints 0.149.0-dev/0.150.0-dev as version Jul 21, 2023
@cPu1
Copy link
Collaborator

cPu1 commented Jul 21, 2023

I'm expecting this to be coming from https://github.com/eksctl-io/eksctl/blob/main/.goreleaser.yml#L17 - maybe we are missing some env configuration in L13? /cc @cPu1

The env config is correct, the package name, however, is incorrect in ldflags.

I have opened a PR with a fix, we'll aim to get it out in the next release.

@cPu1 cPu1 self-assigned this Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants