Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] eksctl utils update-coredns image interpolation broken #7125

Closed
Guillermogsjc opened this issue Sep 29, 2023 · 4 comments · Fixed by #7126
Closed

[Bug] eksctl utils update-coredns image interpolation broken #7125

Guillermogsjc opened this issue Sep 29, 2023 · 4 comments · Fixed by #7126
Labels

Comments

@Guillermogsjc
Copy link

Guillermogsjc commented Sep 29, 2023

when deploying k8s 1.28 with eksctl v0.160.0, coredns will not arrive because of Error: InvalidImageName, with a more specific message:

Failed to apply default image tag "602401143452.dkr.ecr.ap-northeast-2.amazonaws.com/eks/coredns:v1.10.1-eksbuild.3%!(EXTRA string=602401143452, string=eu-west-1, string=amazonaws.com)": couldn't parse image name "602401143452.dkr.ecr.ap-northeast-2.amazonaws.com/eks/coredns:v1.10.1-eksbuild.3%!(EXTRA string=602401143452, string=eu-west-1, string=amazonaws.com)": invalid reference format

looks like an issue related with string interpolation on the image name

image

I can see two replicasets created for coredns, one with that bad interpolated image name

image

I guess that this command

eksctl utils update-coredns --approve --cluster ${CLUSTER_NAME}

that it is being executed in the pipeline right after creation of nodegroups, is patching the image name with the bad interpolated string.

eksctl version: 0.160.0
kubectl version: v1.28.1-eks-43840fb
OS: linux

@Guillermogsjc Guillermogsjc changed the title [Bug] coredns image interpolation broken [Bug] eksctl utils update-coredns iamge interpolation broken Sep 29, 2023
@Guillermogsjc Guillermogsjc changed the title [Bug] eksctl utils update-coredns iamge interpolation broken [Bug] eksctl utils update-coredns image interpolation broken Sep 29, 2023
@Himangini Himangini mentioned this issue Oct 2, 2023
7 tasks
@Himangini
Copy link
Collaborator

@Guillermogsjc thanks for reporting the issue, I have added a PR to fix this error.

@Himangini
Copy link
Collaborator

The PR is merged, we'll release the changes soon.

@AdamDomagalsky
Copy link

AdamDomagalsky commented Oct 12, 2023

same issue with eksctl: 0.161.0, EKS: v1.28.1-eks-43840fb
602401143452.dkr.ecr.ap-northeast-2.amazonaws.com/eks/coredns:v1.10.1-eksbuild.3%!(EXTRA string=602401143452, string=eu-west-1, string=amazonaws.com) as workaround I've replaced coredns deployment image to 602401143452.dkr.ecr.eu-west-1.amazonaws.com/eks/coredns:v1.10.1-eksbuild.3

@cPu1
Copy link
Collaborator

cPu1 commented Oct 13, 2023

same issue with eksctl: 0.161.0, EKS: v1.28.1-eks-43840fb 602401143452.dkr.ecr.ap-northeast-2.amazonaws.com/eks/coredns:v1.10.1-eksbuild.3%!(EXTRA string=602401143452, string=eu-west-1, string=amazonaws.com) as workaround I've replaced coredns deployment image to 602401143452.dkr.ecr.eu-west-1.amazonaws.com/eks/coredns:v1.10.1-eksbuild.3

@AdamDomagalsky, the fix was released in https://github.com/eksctl-io/eksctl/releases/tag/v0.162.0-rc.0, and not 0.161.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants