Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore unsupported zone types when creating a zone mapping #7204

Merged
merged 1 commit into from
Dec 27, 2023

Conversation

cPu1
Copy link
Collaborator

@cPu1 cPu1 commented Oct 20, 2023

Description

Fixes #7202

This part of the codebase lacks tests, so no new tests are being introduced in this changelist.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 馃く

  • Backfilled missing tests for code in same general area 馃帀
  • Refactored something and made the world a better place 馃専

@github-actions github-actions bot added the stale label Dec 1, 2023
@github-actions github-actions bot closed this Dec 7, 2023
@cPu1 cPu1 reopened this Dec 7, 2023
@cPu1 cPu1 removed the stale label Dec 7, 2023
@a-hilaly
Copy link
Member

@cPu1 @TiberiuGC Can we get this shipped?

@cPu1
Copy link
Collaborator Author

cPu1 commented Dec 20, 2023

@cPu1 @TiberiuGC Can we get this shipped?

This will be out in the next release.

@cPu1 cPu1 merged commit b9e936c into eksctl-io:main Dec 27, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants