Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix outdated links #7297

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Fix outdated links #7297

merged 1 commit into from
Jan 19, 2024

Conversation

guessi
Copy link
Contributor

@guessi guessi commented Nov 17, 2023 •
edited by Himangini

Description

Some legacy Amazon EKS doc links need update as upstream doc changed location.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 馃く

  • Backfilled missing tests for code in same general area 馃帀
  • Refactored something and made the world a better place 馃専

@Himangini Himangini added kind/docs User documentation area/docs labels Nov 28, 2023
Himangini
Himangini reviewed Nov 28, 2023
View reviewed changes
Copy link
Collaborator

@Himangini Himangini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the links, they all look good to me.
one small nit.

pkg/awsapi/eks.go Outdated Show resolved Hide resolved
@guessi guessi force-pushed the fix-outdated-links branch 2 times, most recently from e0e9b0e to 38dd957 Compare November 30, 2023 03:53
@guessi
Copy link
Contributor Author

guessi commented Nov 30, 2023

Ummm... Unit test failed with unrelated file change 馃

@guessi
Copy link
Contributor Author

guessi commented Dec 29, 2023

Any chance to get it merged?

@guessi guessi requested a review from Himangini January 12, 2024 14:52
@yuxiang-zhang yuxiang-zhang merged commit 37cc928 into eksctl-io:main Jan 19, 2024
10 checks passed
@guessi guessi deleted the fix-outdated-links branch January 20, 2024 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuxiang-zhang yuxiang-zhang yuxiang-zhang approved these changes

@Himangini Himangini Awaiting requested review from Himangini

Assignees
No one assigned
Labels
kind/docs User documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@guessi @Himangini @yuxiang-zhang